Bug 1902192

Summary:	[RFE][External] RGW metrics should be made available even if anything else except 9283 is provided as the monitoring-endpoint-port
Product:	[Red Hat Storage] Red Hat OpenShift Container Storage	Reporter:	Sébastien Han <shan>
Component:	ocs-operator	Assignee:	arun kumar mohan <amohan>
Status:	CLOSED ERRATA	QA Contact:	Sidhant Agrawal <sagrawal>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.6	CC:	amohan, assingh, bkunal, ebenahar, edonnell, jarrpa, jthottan, madam, muagarwa, nberry, ocs-bugs, rgeorge, sagrawal, shan, sostapov, uchapaga
Target Milestone:	---	Keywords:	AutomationBackLog, FutureFeature
Target Release:	OCS 4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.7.0-722.ci	Doc Type:	Enhancement
Doc Text:	.`ocs-operator` accepts non-default ports for monitoring services Previously, there were no provisions in the `ocs-operator` to pass on a monitoring Prometheus service port other than the default port 9283. This made the port unusable for monitoring services. With this update, the `ocs-operator` has been enabled to accept and propagate non-default monitoring ports from external cluster JSON input and monitoring services work as expected.	Story Points:	---
Clone Of:	1894412	Environment:
Last Closed:	2021-05-19 09:16:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1894412, 1904105
Bug Blocks:	1938134

Comment 2 Sébastien Han 2020-11-27 09:55:22 UTC

Arun, when someone runs the script with the --monitoring-endpoint-port option, we must now must edit the CephCluster spec with:

spec.Monitoring.Port

Please implement this.

Comment 4 Sébastien Han 2020-11-27 11:06:45 UTC

Done!

Comment 5 umanga 2020-12-14 04:39:14 UTC

*** Bug 1904105 has been marked as a duplicate of this bug. ***

Comment 10 Mudit Agarwal 2020-12-15 13:05:09 UTC

Some points to avoid confusion:

1. Yes, we need this fix in 4.7 as Bug #1894412 is also targeted for 4.7
2. We don't have all the approvals despite having dev and qa ack because it is an RFE, and hence not auto approved (we can get the remaining ack)
3. 4.7 is still not in dev freeze mode, so we actually don't need the acks.
4. And given that it is not a big feature, IMHO this can be fixed after feature freeze (before dev freeze)

Comment 11 Yaniv Kaul 2020-12-15 13:45:08 UTC

(In reply to Mudit Agarwal from comment #10)
> Some points to avoid confusion:
> 

...

> 3. 4.7 is still not in dev freeze mode, so we actually don't need the acks.

You actually do, if you want QE to test it. You are not supposed to 'surprise' QE with features.

Comment 12 arun kumar mohan 2020-12-17 13:30:32 UTC

(In reply to leseb from comment #2)
> Arun, when someone runs the script with the --monitoring-endpoint-port
> option, we must now must edit the CephCluster spec with:
> 
> spec.Monitoring.Port
> 
> Please implement this.

This is a two fold process.

Need the latest rook release version, v1.5.3 to make this change, as the Port feature is available in that version only.

That means,
a. Update the rook version to v1.5.3 in OCS-Operator
b. then add the changes which Seb suggested

Preparing the two PRs

Comment 13 arun kumar mohan 2020-12-17 14:31:47 UTC

PRs are up,

a. Updating rook to v1.5.3: https://github.com/openshift/ocs-operator/pull/965
b. Changes to configure Port: https://github.com/openshift/ocs-operator/pull/966

@Michael Adam, @Jose, please take a look

Comment 15 arun kumar mohan 2021-02-08 11:42:20 UTC

Both the PRs (for upgrading rook and the fix for this BZ) are merged in OCS-Operator master.

Following Backport PRs have created,

Rook upgradation PR: https://github.com/openshift/ocs-operator/pull/1045
Fix for the BZ: https://github.com/openshift/ocs-operator/pull/1046

Comment 18 arun kumar mohan 2021-03-08 05:48:58 UTC

Done.

Comment 21 Erin Donnelly 2021-04-13 20:25:04 UTC

Thank you for the doc text Arun! Could you take a look at my edited version and let me know if it's okay? Thanks.

Comment 23 errata-xmlrpc 2021-05-19 09:16:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Container Storage 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2041