Bug 1902397
| Summary: | Review Request: rust-dummy - Macros implementation of #[derive(Dummy)] | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Olivier Lemasle <o.lemasle> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | o.lemasle, package-review |
| Target Milestone: | --- | Flags: | o.lemasle:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-01-12 18:21:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1892930 | ||
|
Description
Fabio Valentini
2020-11-28 13:22:09 UTC
It does not build in mock:
Running `/usr/bin/rustc --crate-name dummy --edition=2018 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C opt-level=3 -C embed-bitcode=no -C metadata=34e7f9c5fb098e3e -C extra-filename=-34e7f9c5fb098e3e --out-dir /builddir/build/BUILD/dummy-0.3.3/target/release/deps -L dependency=/builddir/build/BUILD/dummy-0.3.3/target/release/deps --extern darling=/builddir/build/BUILD/dummy-0.3.3/target/release/deps/libdarling-991f04f44011cefa.rlib --extern quote=/builddir/build/BUILD/dummy-0.3.3/target/release/deps/libquote-9b517b766eaaf53c.rlib --extern syn=/builddir/build/BUILD/dummy-0.3.3/target/release/deps/libsyn-6eb5363a317fe24a.rlib --extern proc_macro -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now -Ccodegen-units=1 --cap-lints=warn`
error: pattern requires `..` due to inaccessible fields
--> src/lib.rs:51:36
|
51 | darling::ast::Data::Struct(darling::ast::Fields {
| ____________________________________^
52 | | ref fields,
53 | | ref style,
54 | | }) => match style {
| |_________^
|
help: ignore the inaccessible and unused fields
|
53 | ref style, ..,
| ^^^^
error: aborting due to previous error
error: could not compile `dummy`
However, it seems it work with latest upstream release (0.4.0).
Oh ... I think this might be caused by having a version of darling in fedora that was pulled by upstream :( I'll look into updating to 0.4.0. Spec URL: https://decathorpe.fedorapeople.org/packages/rust-dummy.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-dummy-0.4.0-1.fc33.src.rpm You were right. 0.4.0 compiles successfully. Package accepted.
- License ok
- Spec generated by rust2rpm; only variation is related to additional %license.
- Latest upstream is packaged
- Guidelines and naming conventions ok
- Builds in mock
Rpmlint
-------
Checking: rust-dummy-devel-0.4.0-1.fc34.noarch.rpm
rust-dummy+default-devel-0.4.0-1.fc34.noarch.rpm
rust-dummy-0.4.0-1.fc34.src.rpm
rust-dummy-devel.noarch: W: invalid-url URL: https://crates.io/crates/dummy HTTP Error 404: Not Found
rust-dummy-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/dummy-0.4.0/.cargo-checksum.json
rust-dummy+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/dummy HTTP Error 404: Not Found
rust-dummy+default-devel.noarch: W: no-documentation
rust-dummy.src: W: invalid-url URL: https://crates.io/crates/dummy HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
Thank you for the review! :) https://pagure.io/releng/fedora-scm-requests/issue/31714 I'll look at one or two of your pending Rust packages in turn. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dummy Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1668461 |