Description of problem:
It seems like the conditionals for %{?_enable_debug_packages} and %{with benchtests} have been mixed up in the spec file. Building with "--define '_enable_debug_packages 0' --without benchtests" leads to build failures.
Version-Release number of selected component (if applicable):
glibc-2.28-127.el8
How reproducible:
Everytime with "--define '_enable_debug_packages 0' --without benchtests" options at build-time.
Actual results:
--- 8< ---
--- glibc.spec
+++ glibc.spec.rsc
@@ -1514,8 +1514,8 @@ cp benchtests/scripts/benchout.schema.json %{glibc_sysroot}%{_prefix}/libexec/gl
cp benchtests/scripts/compare_bench.py %{glibc_sysroot}%{_prefix}/libexec/glibc-benchtests/
cp benchtests/scripts/import_bench.py %{glibc_sysroot}%{_prefix}/libexec/glibc-benchtests/
cp benchtests/scripts/validate_benchout.py %{glibc_sysroot}%{_prefix}/libexec/glibc-benchtests/
+%endif
-%if 0%{?_enable_debug_packages}
# The #line directives gperf generates do not give the proper
# file name relative to the build directory.
pushd locale
@@ -1875,6 +1875,7 @@ test $(wc -l < libnsl.filelist) -eq 1
# glibc-benchtests
###############################################################################
+%if %{with benchtests}
# List of benchmarks.
find build-%{target}/benchtests -type f -executable | while read b; do
echo "%{_prefix}/libexec/glibc-benchtests/$(basename $b)"
@@ -1899,6 +1900,7 @@ echo "%{_libdir}/libpthread_nonshared.a" >> compat-libpthread-nonshared.filelist
# glibc-debuginfocommon, and glibc-debuginfo
###############################################################################
+%if 0%{?_enable_debug_packages}
find_debuginfo_args='--strict-build-id -g -i'
%ifarch %{debuginfocommonarches}
find_debuginfo_args="$find_debuginfo_args \
--- 8< ---
Expected results:
Above patch or better being applied to glibc.spec
Description of problem: It seems like the conditionals for %{?_enable_debug_packages} and %{with benchtests} have been mixed up in the spec file. Building with "--define '_enable_debug_packages 0' --without benchtests" leads to build failures. Version-Release number of selected component (if applicable): glibc-2.28-127.el8 How reproducible: Everytime with "--define '_enable_debug_packages 0' --without benchtests" options at build-time. Actual results: --- 8< --- --- glibc.spec +++ glibc.spec.rsc @@ -1514,8 +1514,8 @@ cp benchtests/scripts/benchout.schema.json %{glibc_sysroot}%{_prefix}/libexec/gl cp benchtests/scripts/compare_bench.py %{glibc_sysroot}%{_prefix}/libexec/glibc-benchtests/ cp benchtests/scripts/import_bench.py %{glibc_sysroot}%{_prefix}/libexec/glibc-benchtests/ cp benchtests/scripts/validate_benchout.py %{glibc_sysroot}%{_prefix}/libexec/glibc-benchtests/ +%endif -%if 0%{?_enable_debug_packages} # The #line directives gperf generates do not give the proper # file name relative to the build directory. pushd locale @@ -1875,6 +1875,7 @@ test $(wc -l < libnsl.filelist) -eq 1 # glibc-benchtests ############################################################################### +%if %{with benchtests} # List of benchmarks. find build-%{target}/benchtests -type f -executable | while read b; do echo "%{_prefix}/libexec/glibc-benchtests/$(basename $b)" @@ -1899,6 +1900,7 @@ echo "%{_libdir}/libpthread_nonshared.a" >> compat-libpthread-nonshared.filelist # glibc-debuginfocommon, and glibc-debuginfo ############################################################################### +%if 0%{?_enable_debug_packages} find_debuginfo_args='--strict-build-id -g -i' %ifarch %{debuginfocommonarches} find_debuginfo_args="$find_debuginfo_args \ --- 8< --- Expected results: Above patch or better being applied to glibc.spec