Bug 1902545

Summary:	Cinder csi driver node pod should add nodeSelector for Linux
Product:	OpenShift Container Platform	Reporter:	Wei Duan <wduan>
Component:	Storage	Assignee:	Matthew Booth <mbooth>
Storage sub component:	OpenStack CSI Drivers	QA Contact:	Wei Duan <wduan>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	aos-bugs, m.andre, pprinett
Version:	4.7	Keywords:	UpcomingSprint
Target Milestone:	---
Target Release:	4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-24 15:36:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Wei Duan 2020-11-30 02:46:43 UTC

Description of problem:
Cinder-csi-driver-node pod should add nodeSelector for Linux node only

Version-Release number of selected component (if applicable):
4.7.0-0.nightly-2020-11-29-133728

Steps to Reproduce:
1. Install OSP cluster and cinder csi driver is installed. 

2. Check CSI driver node pods:
   oc -n openshift-cluster-csi-drivers get pod openstack-cinder-csi-driver-node-42svt -o yaml

Actual results:
CSI driver node pods does not have nodeSelector for Linux

Expected results:
CSI driver node pods need nodeSelector for Linux in case we support windows node on OSP in the future.
Example for aws ebs driver:
https://github.com/openshift/aws-ebs-csi-driver-operator/blob/master/assets/node.yaml#L20-L21

Comment 1 Martin André 2020-12-10 09:14:07 UTC

This needs tweaking the yaml manifest file.

Comment 3 Wei Duan 2021-01-07 01:42:23 UTC

Verified pass on 4.7.0-0.nightly-2021-01-06-094712

$ oc -n openshift-cluster-csi-drivers get pod openstack-cinder-csi-driver-node-4f2g9 -o yaml | grep "linux" -B 1
  nodeSelector:
    kubernetes.io/os: linux

Comment 6 errata-xmlrpc 2021-02-24 15:36:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633