Bug 1902696

Summary: regression running staprun under a stapusrer ID (rhel-8.3 vs. rhel-8.4)
Product: Red Hat Enterprise Linux 8 Reporter: Martin Cermak <mcermak>
Component: systemtapAssignee: Frank Ch. Eigler <fche>
systemtap sub component: system-version QA Contact: Martin Cermak <mcermak>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: lberk, mcermak, mcoufal, mjw, vkadlcik
Version: 8.4Keywords: Bugfix, Triaged
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemtap-4.4-8.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1908904 (view as bug list) Environment:
Last Closed: 2021-05-18 15:44:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Cermak 2020-11-30 12:50:29 UTC
Upstream commit 7615cae790c899bc8a82841c75c8ea9c6fa54df3 broke staprun's ability to insert a module under a stapusr ID:


----> su stapusrer -c 'staprun -vvvvv /lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko'
staprun:parse_modpath:430 inpath=/lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko
staprun:main:485 modpath="/lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko", modname="dummy"
staprun:init_staprun:391 init_staprun
staprun:insert_module:71 inserting module /lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko
staprun:insert_module:97 module options: _stp_bufsize=0
staprun:insert_module:105 module path canonicalized to '/usr/lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko'
staprun:check_signature:427 checking signature for /usr/lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko
Signature file /usr/lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko.sgn not found
staprun:check_signature:440 verify_module returns 0
staprun:insert_module:191 Module dummy inserted from file /usr/lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko
ERROR: Couldn't insert module '/lib/modules/4.18.0-240.1.1.el8_3.x86_64/systemtap/dummy.ko': File exists
ERROR: Rerun with staprun option '-R' to rename this module.
----> 


There is one old and stable qe test covering this.  It now fails on line 93 here:

http://pkgs.devel.redhat.com/cgit/tests/systemtap/tree/Security/CVE-2011-2502-staprun-able-to-load-arbirary-module-OF/runtest.sh#n93

Rollong back commit 7615cae790c899bc8a82841c75c8ea9c6fa54df3 does fix the issue.

Comment 1 Martin Cermak 2020-11-30 14:27:56 UTC
The problem seems to be in init_ctl_channel() :



# su stapusrer -c 'staprun  -vvvvv /lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko'
staprun:parse_modpath:430 inpath=/lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko
staprun:main:485 modpath="/lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko", modname="dummy"
staprun:init_staprun:391 init_staprun
staprun:insert_module:71 inserting module /lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko
staprun:insert_module:97 module options: _stp_bufsize=0
staprun:insert_module:105 module path canonicalized to '/usr/lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko'
staprun:check_signature:427 checking signature for /usr/lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko
Signature file /usr/lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko.sgn not found
staprun:check_signature:440 verify_module returns 0
staprun:insert_module:191 Module dummy inserted from file /usr/lib/modules/4.18.0-254.el8.x86_64/systemtap/dummy.ko
staprun:init_ctl_channel:92 Opened  (-1)
ERROR: Cannot attach to module dummy control channel; not running?
staprun:remove_module:246 dummy
staprun:init_ctl_channel:92 Opened  (-1)
ERROR: Cannot attach to module dummy control channel; not running?
ERROR: 'dummy' is not a zombie systemtap module.
#

Comment 2 Frank Ch. Eigler 2020-12-14 02:17:08 UTC
fixed upstream
https://sourceware.org/bugzilla/show_bug.cgi?id=23512

Comment 3 Frank Ch. Eigler 2020-12-14 02:20:55 UTC
correction,
https://sourceware.org/bugzilla/show_bug.cgi?id=27067

Comment 7 errata-xmlrpc 2021-05-18 15:44:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (systemtap bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1829