Bug 190345
| Summary: | Review Request: vdr-femon - DVB frontend status monitor plugin for VDR | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <scop> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-06 12:48:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 190343 | ||
| Bug Blocks: | 163779 | ||
|
Description
Ville Skyttä
2006-05-01 14:05:30 UTC
http://cachalot.mine.nu/5/SRPMS/vdr-femon-1.0.1-1.src.rpm * Mon Jun 12 2006 Ville Skyttä <ville.skytta at iki.fi> - 1.0.1-1 - 1.0.1, build for VDR 1.4.1. http://cachalot.mine.nu/5/SRPMS/vdr-femon.spec http://cachalot.mine.nu/5/SRPMS/vdr-femon-1.1.0-1.src.rpm * Sat Sep 23 2006 Ville Skyttä <ville.skytta at iki.fi> - 1.1.0-1 - 1.1.0, build for VDR 1.4.3. Updated URLs, no changes to package: http://cachalot.mine.nu/6/SRPMS/vdr-femon.spec http://cachalot.mine.nu/6/SRPMS/vdr-femon-1.1.0-1.src.rpm I'd be happy to review this package. Look for a detailed review in a bit. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 845886d484d998e79f997320f53bbf6d vdr-femon-1.1.0.tgz 845886d484d998e79f997320f53bbf6d vdr-femon-1.1.0.tgz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. i386/x86_64 - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: I don't see any blockers here, so this package is APPROVED. Don't forget to close this review request NEXTRELEASE once it's been imported and built. Also consider doing a review of another waiting package in the review queue. Built for FC5+, owners.list and comps updated. Thanks! |