Bug 1903589

This also blocks bug 1905835.

Stanislav, can you please have a look?

it looks like mockbuild was refactored. the following "patch" has fixed the issue and let my fedora-review to run:

/usr/lib/python3.8/site-packages/FedoraReview/mock.py
...
 import mockbuild.util
+import mockbuild.config
...
-config_opts = mockbuild.util.load_config(mockdir, config, None, "unknown",  get_paths()['purelib'])
+config_opts = mockbuild.config.load_config(mockdir, config, None, "unknown",  get_paths()['purelib'])

(In reply to Vladis Dronov from comment #2)
> it looks like mockbuild was refactored. the following "patch" has fixed the
> issue and let my fedora-review to run:
> 
> /usr/lib/python3.8/site-packages/FedoraReview/mock.py
> ...
>  import mockbuild.util
> +import mockbuild.config
> ...
> -config_opts = mockbuild.util.load_config(mockdir, config, None, "unknown", 
> get_paths()['purelib'])
> +config_opts = mockbuild.config.load_config(mockdir, config, None,
> "unknown",  get_paths()['purelib'])

I confirm that with that change fedora-review works. Thank you. :-)

Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py", line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks
    self.checks.run_checks(output=output, writedown=not Settings.no_report)
  File "/usr/lib/python3.9/site-packages/FedoraReview/checks.py", line 382, in run_checks
    run_check(name)
  File "/usr/lib/python3.9/site-packages/FedoraReview/checks.py", line 357, in run_check
    check.run()
  File "/usr/lib/python3.9/site-packages/FedoraReview/plugins/generic_build.py", line 203, in run
    Mock.build(self.srpm.filename)
  File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 451, in build
    self.builddir_cleanup()
  File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 578, in builddir_cleanup
    paths = glob(os.path.join(self.get_builddir("BUILD"), "*"))
  File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 354, in get_builddir
    p = self._get_dir(os.path.join("root", self._topdir[1:]))
  File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 195, in _get_dir
    self._get_root()
  File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 180, in _get_root
    config_opts = mockbuild.util.load_config(mockdir, config, None, "unknown",  get_paths()['purelib'])
AttributeError: module 'mockbuild.util' has no attribute 'load_config'

(In reply to Vitaly Zaitsev from comment #4)
> Traceback (most recent call last):
>   File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py",
> line 236, in run
>     self._do_run(outfile)
>   File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py",
> line 226, in _do_run
>     self._do_report(outfile)
>   File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py",
> line 99, in _do_report
>     self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
>   File "/usr/lib/python3.9/site-packages/FedoraReview/review_helper.py",
> line 117, in _run_checks
>     self.checks.run_checks(output=output, writedown=not Settings.no_report)
>   File "/usr/lib/python3.9/site-packages/FedoraReview/checks.py", line 382,
> in run_checks
>     run_check(name)
>   File "/usr/lib/python3.9/site-packages/FedoraReview/checks.py", line 357,
> in run_check
>     check.run()
>   File
> "/usr/lib/python3.9/site-packages/FedoraReview/plugins/generic_build.py",
> line 203, in run
>     Mock.build(self.srpm.filename)
>   File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 451, in
> build
>     self.builddir_cleanup()
>   File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 578, in
> builddir_cleanup
>     paths = glob(os.path.join(self.get_builddir("BUILD"), "*"))
>   File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 354, in
> get_builddir
>     p = self._get_dir(os.path.join("root", self._topdir[1:]))
>   File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 195, in
> _get_dir
>     self._get_root()
>   File "/usr/lib/python3.9/site-packages/FedoraReview/mock.py", line 180, in
> _get_root
>     config_opts = mockbuild.util.load_config(mockdir, config, None,
> "unknown",  get_paths()['purelib'])
> AttributeError: module 'mockbuild.util' has no attribute 'load_config'

Hi Vitaly,
  did you try to apply the change described in comment #2 to the file where this occurs?

Instead of /usr/lib/python3.8/site-packages/FedoraReview/mock.py we need to fix
/usr/lib/python3.9/site-packages/FedoraReview/mock.py (python 3.8 is on Fedora 32 while 3.9 is on Fedora 33).

> did you try to apply the change described in comment #2 to the file where this occurs?

Yes. The suggested patch works fine.

I too have the same problem (fedora-review-0.7.6-1.fc33.noarch, mock-2.7-1.fc33.noarch), and I can also confirm the patch.

I really need to hand over FR to someone else. I can't remember last time I added a package to Fedora (or touched FR) and it's just not something I spend time on anymore.

I'll ask folks who have been active more recently to take over...

This package has changed maintainer in the Fedora.
Reassigning to the new maintainer of this component.

I had the same problem with fedora-review-0.7.5-1.fc32.noarch and the patch in comment #2 fixed it.

Encountered same problem with fedora-review-0.7.6-1.fc33, patch in comment #2 fixed that.

FEDORA-2020-cb162a867d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-cb162a867d

FEDORA-2020-cb162a867d has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-cb162a867d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-cb162a867d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-58c4aa6514 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-58c4aa6514`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-58c4aa6514

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-58c4aa6514 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2020-cb162a867d has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.