Bug 1903686

Summary:	Review Request: xmlezout - set of packages intended to aid the creation of XML-formatted output from within Ada programs
Product:	[Fedora] Fedora	Reporter:	Pavel Zhukov <pzhukov>
Component:	Package Review	Assignee:	Andy Mender <andymenderunix>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	andymenderunix, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-29 00:45:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Pavel Zhukov 2020-12-02 16:10:01 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/landgraf/alire-review/fedora-rawhide-x86_64/01809070-xmlezout/xmlezout.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/landgraf/alire-review/fedora-rawhide-x86_64/01809070-xmlezout/xmlezout-20201202-2.20201202git1fcbd0b9.fc34.src.rpm
Description: XML EZ_Out is a small set of packages intended to aid the creation of XML-formatted output from within Ada programs
Fedora Account System Username: landgraf

Comment 1 Pavel Zhukov 2020-12-02 16:15:16 UTC

failed to build in rawhide. Waiting for https://src.fedoraproject.org/rpms/fedora-gnat-project-common/pull-request/1

Comment 2 Andy Mender 2020-12-05 13:28:45 UTC

> Release: 2.%{git_suffix}%{?dist}
> License: GPLv2+
> Group: Development/Libraries

- The Group field is obsolete.

- Not sure about the license. The project doesn't have a license file (the patch you submitted adds it, in fact) and the text I see in some files would fit "GPL+ with exceptions" or "GPLv2 with exceptions" more, I think: https://github.com/alire-project/xmlezout/blob/master/mckae-xml-ez_out-generic_medium.adb

> URL: https://github.com/alire-project/xmlezout
> Source0: https://github.com/alire-project/%{name}/archive/%{git_commit}/%{name}-%{version}.tar.gz

- You can use the URL in the Source0 field with the %{url} macro.

- The downloaded archive is actually "%{name}-%{git_commit}.tar.gz" so an alias might be needed. Or I'm doing something wrong :(.

> BuildRequires: gprbuild gcc-gnat 

Could you split these into separate lines?

> %files
> %defattr(-,root,root,-)

Setting permissions in %files is no longer needed.

I'll wait with a full review until the PR you submitted is in.

Comment 3 Andy Mender 2020-12-28 11:56:55 UTC

> I'll wait with a full review until the PR you submitted is in.

Done. 

However, the package fails to build on Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=58463435

Comment 4 Pavel Zhukov 2020-12-28 12:20:27 UTC

(In reply to Andy Mender from comment #3)
> > I'll wait with a full review until the PR you submitted is in.
> 
> Done. 
> 
> However, the package fails to build on Koji:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=58463435

Macros name has been changed as the result of the review. I'll push updated version with license fixes soon.

Comment 5 Andy Mender 2021-02-14 08:59:35 UTC

Hello Pavel, any updates on this? :)

Comment 6 Pavel Zhukov 2021-03-01 06:03:06 UTC

(In reply to Andy Mender from comment #5)
> Hello Pavel, any updates on this? :)

Hello Andy,

Sorry for the delay. It went out of my radar. Will push updated versions by the EOW. Keeping needinfo as a reminder.

Comment 7 Package Review 2021-03-29 00:45:22 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.