Bug 1904165

Summary:	PV discovery screen raises error in mig-ui related to new direct migration setup
Product:	Migration Toolkit for Containers	Reporter:	Derek Whatley <dwhatley>
Component:	UI	Assignee:	Ian <ibolton>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	unspecified	Docs Contact:	Avital Pinnick <apinnick>
Priority:	unspecified
Version:	1.4.0	CC:	ernelson, ibolton, rjohnson, xjiang
Target Milestone:	---
Target Release:	1.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-11 12:54:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Derek Whatley 2020-12-03 18:24:10 UTC

Description of problem:
https://github.com/konveyor/mig-controller/issues/835

mig-ui is showing a validation failure related to direct migration selections before the user has a chance to select their direct migration settings.

Version-Release number of selected component (if applicable):
1.4.0, latest mig-ui

How reproducible:
Always, in my experience.

Steps to Reproduce:
1. Select namespaces to migrate in mig-ui
2. Proceed to PV discovery step
3. UI will raise error condition warning "Direct image migration is selected and the source cluster openshift-migration/cluster-3 is missing a configured Registry Path"
4. Strangely, the issue seems to be resolved eventually. I checked the spec of the migplan and saw this:

My thought is that the initial migplan created by mig-ui is missing the indirectImageMigration and indirectVolumeMigration settings so the migplan is defaulting to use direct migration.


Expected results:

The migration UI should not throw an error during PV discovery when the user hasn't even had a chance to select indirect/direct migration yet.

This could be solved on controller side by flipping the default and renaming the directImageMigration vars, or it could be fixed in mig-ui by making sure the first version of a migplan that is created has indirectImageMigration and indirectVolumeMigration both set to true.

Comment 1 Derek Whatley 2020-12-03 18:24:56 UTC

I have this set as a controller bug but it could be solved in either mig-controller or mig-ui.

Comment 2 Derek Whatley 2020-12-03 18:50:45 UTC

Switching to mig-ui issue.
https://github.com/konveyor/mig-ui/issues/1079

Comment 3 Ian 2020-12-07 23:20:01 UTC

Addressed with PR https://github.com/konveyor/mig-ui/pull/1080 - pending review and merge

Comment 6 Ian 2020-12-11 22:21:21 UTC

*** Bug 1906340 has been marked as a duplicate of this bug. ***

Comment 10 Xin jiang 2020-12-15 07:30:03 UTC

verified. 
"registry.redhat.io/rhmtc/openshift-migration-rhel7-operator@sha256:61de8be7e30fb15b278aeececb0de8ac5ecaeb221a312ab1140e6c925ab0e217",
 registry.redhat.io/rhmtc/openshift-migration-ui-rhel8@sha256:be417d9a34e4f046bbc9fa4150e6355a6ea4ff61a3c6ec8d2bf3597a76fbacd0

Comment 12 errata-xmlrpc 2021-02-11 12:54:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5329