Bug 1904507

Summary:	vsphere-problem-detector: implement missing metrics
Product:	OpenShift Container Platform	Reporter:	Jan Safranek <jsafrane>
Component:	Storage	Assignee:	Jan Safranek <jsafrane>
Storage sub component:	Operators	QA Contact:	Wei Duan <wduan>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	aos-bugs
Version:	4.7
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:34:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Safranek 2020-12-04 16:25:20 UTC

vsphere-problem-detector does not implement all metrics described in
https://github.com/openshift/enhancements/blob/master/enhancements/storage/vsphere-problem-detector.md#metrics

* Implement the missing ones or update the enhancements to remove them.
* Update telemetry setting to report them to us (or update the enhancement)

Comment 1 Jan Safranek 2020-12-14 14:40:56 UTC

Already merged at feature freeze:
* List of failed periodic tests.
* vCenter version.


https://github.com/openshift/vsphere-problem-detector/pull/12:
* HW version of vSphere VMs.
* ESXi host version (of each host).

Comment 4 Jan Safranek 2021-05-21 13:13:18 UTC

Current list of missing metrics:
List of installed storage plugins (3rd party vendor VIBs) - if possible.
List of enabled features:
 * HA
 * DRS

I did not find a way how to list volume plugins and HA+DRS is IMO not that interesting. I am going to remove them from the enhancement.

In addition, there is a rumor that NFS won't be supported by the CSI driver, https://vsphere-csi-driver.sigs.k8s.io/compatiblity_matrix.html
> vSphere CSI driver does not support provisioning volumes on NFSv4 Datastore.

I'm adding a metric for datastore types, so we know how much NFS is used.

Comment 6 Wei Duan 2021-06-10 07:47:46 UTC

Verified pass on 4.8.0-0.nightly-2021-06-09-142759
{
  "status": "success",
  "data": {
    "resultType": "vector",
    "result": [
      {
        "metric": {
          "__name__": "vsphere_datastore_total",
          "container": "vsphere-problem-detector-operator",
          "endpoint": "vsphere-metrics",
          "instance": "10.130.0.67:8444",
          "job": "vsphere-problem-detector-metrics",
          "namespace": "openshift-cluster-storage-operator",
          "pod": "vsphere-problem-detector-operator-6dc67d66f4-sprwc",
          "service": "vsphere-problem-detector-metrics",
          "type": "vsan"
        },
        "value": [
          1623309572.568,
          "1"
        ]
      }
    ]
  }
}

Comment 9 errata-xmlrpc 2021-07-27 22:34:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438