Bug 1905323

Summary: dns-operator is not requesting required memory resource
Product: OpenShift Container Platform Reporter: W. Trevor King <wking>
Component: NetworkingAssignee: Ryan Fredette <rfredette>
Networking sub component: DNS QA Contact: jechen <jechen>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: amcdermo, aos-bugs, hongli, jechen
Version: 4.7   
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.7.0-0.nightly-2021-01-18-144603 Doc Type: Bug Fix
Doc Text:
Cause: Several containers in the dns-operator deployment and the coredns daemonset did not include memory requests Consequence: Pods with these containers could be scheduled to nodes that did not have enough memory available Fix: All containers in the dns-operator deployment and coredns daemonset request appropriate amounts of memory Result: dns-operator and coredns pods will only be scheduled for nodes that have sufficient memory
 Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-24 15:40:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description W. Trevor King 2020-12-08 03:23:13 UTC 
This bug was initially created as a copy of Bug #1905298, but for the DNS operator.  Containers must set both memory and CPU requests going forward [1], while [2] is showing:

openshift-dns-operator/dns-operator-7bd8ddd7b5-hgnql container containers[0] (dns-operator) is not requesting required resources: memory
openshift-dns/dns-default-d98zt container containers[2] (dns-node-resolver) is not requesting required resources: memory
openshift-dns/dns-default-fgdvs container containers[2] (dns-node-resolver) is not requesting required resources: memory
openshift-dns/dns-default-grxdr container containers[2] (dns-node-resolver) is not requesting required resources: memory
openshift-dns/dns-default-hmlns container containers[2] (dns-node-resolver) is not requesting required resources: memory
openshift-dns/dns-default-mr89g container containers[2] (dns-node-resolver) is not requesting required resources: memory
openshift-dns/dns-default-pnkcp container containers[2] (dns-node-resolver) is not requesting required resources: memory

as part of failing:

  [sig-arch] Managed cluster should ensure control plane containers have requests set for cpu and memory [Suite:openshift/conformance/parallel]

origin/25747 is in flight to transition an existing, but overly relaxed, test-case to explicitly require both requests on all containers.  Any components which have not been fixed after an initial pass will have temporary exceptions linked to their tracking bugs when the stricter test lands.

[1]: https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits
[2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25747/pull-ci-openshift-origin-master-e2e-gcp/1336048716389289984
Comment 2 jechen 2021-01-19 01:51:19 UTC 
[jechen@jechen ~]$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.7.0-0.nightly-2021-01-18-144603   True        False         6h6m    Cluster version is 4.7.0-0.nightly-2021-01-18-144603


[jechen@jechen ~]$ oc -n openshift-dns-operator get deployment/dns-operator -oyaml
<---snip--->
        name: dns-operator
        resources:
          requests:
            cpu: 10m
            memory: 29Mi

[jechen@jechen ~]$ oc -n openshift-dns get ds/dns-default -oyaml
<---snip--->
        name: dns-node-resolver
        resources:
          requests:
            cpu: 5m
            memory: 21Mi
Comment 5 errata-xmlrpc 2021-02-24 15:40:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633