Bug 1905378

Summary:	ExtraConfigPre and NodeExtraConfig are executed before network settings are applied
Product:	Red Hat OpenStack	Reporter:	Takashi Kajinami <tkajinam>
Component:	openstack-tripleo-heat-templates	Assignee:	OSP Team <rhos-maint>
Status:	CLOSED ERRATA	QA Contact:	Joe H. Rahme <jhakimra>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	16.1 (Train)	CC:	aschultz, cjeanner, gchamoul, kecarter, mburns, nbourgeo, nsatsia, pkundal, ramishra, sputhenp, sthennak
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-11.3.2-1.20210621153311.29a02c1.el8ost openstack-tripleo-common-11.4.1-1.20210621153311.75bd92a.el8ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-09 20:17:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Takashi Kajinami 2020-12-08 08:26:45 UTC

Description of problem:

In RHOSP16.1, ExtraConfigPre and NodeExtraConfig, are executed before network configuration was applied. This is different from RHOSP13, in which these resources are executed after network configuration.

Some users currently use these resources to apply some configurations which depend on network connectivity on networks which are different from provisioning network in RHOSP13, and this change in resource order causes failure with such implementations in RHPOSP16.1.


Version-Release number of selected component (if applicable):

How reproducible:
Always

Steps to Reproduce:
1. Define ExtraConfigPre resource and NodeExtraConfig resource in deployment templates
2. Run overcloud deployment
3. See when these resources are executed

Actual results:
ExtraConfigPre and NodeExtraConfig are executed before network settings are applied

Expected results:
ExtraConfigPre and NodeExtraConfig are executed after network settings are applied

Additional info:

Comment 1 Alex Schultz 2020-12-08 14:54:00 UTC

I checked and the order did change. I'm not certain we should switch it back or just document this new order. These actions run before the network setup so they can be used to install network drivers, etc that would be needed for the network configuration. ExtraConfigPre & ExtraConfig should be used for hiera so it shouldn't matter if that is invoked prior to the network configuration.  It sounds like these are custom things being used by the customer so maybe they need to be converted to use something else.

Comment 2 Takashi Kajinami 2020-12-08 15:30:48 UTC

Thank you for your thoughts, Alex,

> These actions run before the network setup so they can be used to install network drivers, etc that would be needed for the network configuration.
For that use case we already have the PreNetworkConfig resource (and we can use NodeUserData resource once bz 1903120 is fixed).

IMHO it's useful to have configuration hook between network configuration and other ansible/puppet invocation,
which allows us to run tasks with network connectivity (For example we can run some initialization for storage backend).

In RHOSP13 I used to use this hook to set up nfs storage for Gnocchi since it was not yet supported by TripleO.

> ExtraConfigPre & ExtraConfig should be used for hiera so it shouldn't matter if that is invoked prior to the network configuration.
ExtraConfigPre is not for injecting hiera but for running configuration tasks.

Comment 4 Alex Schultz 2021-01-06 16:14:48 UTC

We should document this change as part of the 16.x upgrades. Any thing that really needs to be handled prior to the network configuration should likely be included in a firstboot

Comment 35 errata-xmlrpc 2021-12-09 20:17:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.7 (Train) bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:3762