Bug 1905394

Summary:	CPU validation fails with VM custom compatibility version
Product:	[oVirt] ovirt-engine	Reporter:	Lucia Jelinkova <ljelinko>
Component:	BLL.Virt	Assignee:	Lucia Jelinkova <ljelinko>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Tamir <tamir>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4.3	CC:	ahadas, bugs, sfroemer
Target Milestone:	ovirt-4.4.5	Flags:	pm-rhel: ovirt-4.4+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.5.6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-18 15:14:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lucia Jelinkova 2020-12-08 09:13:14 UTC

Description of problem:
When adding/editing a VM, there is a validation if the cluster CPU is correct. However, the validation fails if the VM uses custom compatibility version and the CPU has been removed/renamed between versions. Even if the custom cpu is set, the validation fails because it always checks the cluster cpu.

Steps to Reproduce:
1.Create a 4.4 cluster with some Secure CPU
2.Create a VM in the cluster with custom compatibility version 4.3 and a custom cpu

Actual results:
The validation fails and a VM cannot be created. The error message says:
The CPU type of the cluster is unknown. Its possible to change the cluster cpu or set a different one per VM.

Expected results:
The VM could be created if a custom compatibility version is selected as well as custom cpu. If no cpu is selected, the error message should be changed to: The CPU type of the cluster is unknown in the current compatibility version. Please select a custom cpu type.

Comment 1 Arik 2020-12-09 09:57:13 UTC

(In reply to Lucia Jelinkova from comment #0)
> Expected results:
> The VM could be created if a custom compatibility version is selected as
> well as custom cpu. If no cpu is selected, the error message should be
> changed to: The CPU type of the cluster is unknown in the current
> compatibility version. Please select a custom cpu type.

Or to avoid this situation - if the we don't allow setting to set lower custom compatibility version, then to fail cluster upgrade when there's a VM/template that is set with custom compatibility version that is lower than the one we upgrade to

Comment 2 Tamir 2021-02-21 13:55:52 UTC

Verified on RHV 4.4.5-6. All looks good to me.

Env:
  - Engine instance with RHV 4.4.5-6 (ovirt-engine-4.4.5.6-0.11.el8ev) and RHEL 8.3 installed.
  - 1 host with RHV 4.4.5-6 and RHEL 8.3 with vdsm-4.40.50.6-1.el8ev

Steps:
1. Create a 4.3 data center and a 4.4 cluster.
2. Install the host and create a new NFS storage domain.
3. Create a VM with custom compatibility version 4.3 and a custom CPU. 


Results (As Expected):
Actual results:
1. The 4.3 data center and the 4.4 cluster were created.
2. The host was installed and the NFS storage domain was created.
3. The VM was created successfully.

Comment 3 Sandro Bonazzola 2021-03-18 15:14:03 UTC

This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 4 Sandro Bonazzola 2021-03-22 12:55:38 UTC

This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.