Bug 1905687
| Summary: | Backport "Fortran dynamic type related fixes" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Keith Seitz <keiths> | ||||
| Component: | gdb | Assignee: | Keith Seitz <keiths> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 32 | CC: | jan.kratochvil, keiths, kevinb, pmuldoon, sergiodj | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | gdb-9.1-7.fc32 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1905701 1905702 1905704 (view as bug list) | Environment: | |||||
| Last Closed: | 2020-12-21 01:35:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1905701, 1905702, 1905704 | ||||||
| Attachments: |
|
||||||
Created attachment 1737710 [details]
GDB test/reproducer
Testing patch. FEDORA-2020-7a59e08355 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7a59e08355 FEDORA-2020-7a59e08355 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7a59e08355` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7a59e08355 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-7a59e08355 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |
Originally reported/triaged by Andrew Dinn: I have run up against a problem with the versions of gdb that are out in the field that relates to the use of data_location properties on DWARF class/struct info records. I need to use this DWARF feature in order to fully implement Java debuginfo for GraalVM native Java apps. The data_location attribute is needed to ensure that Java oops (typed as DWARF pointer types which reference the underlying class/struct data) are adjusted from a Java-specific encoding of the address to a direct memory pointer before gdb dereferences the oop to locate the underlying data. - In one mode of image generation oops are addresses modulo extra tag info in the bottom 3 bits so a locexpr describes how to mask off the relevant bits. - In another mode of image generation oops are offsets from a heap base held in a register so a locexpr describes how to fetch the relevant register value and add it to the oop (offset). The data_location attribute on the target object provides the necessary locexpr. My problem is not to do with the conversion itself. That all works fine. It goes wrong when I ask gdb to print the relevant object data (see example after sig). The value that gets inserted into the history has an unresolved dynamic type and this trips an assert . This problem should be caught and dealt with before the value is passed to the print code and indeed it has been fixed in gdb 10.1. The patch is detailed in the asssociated ChangeLog as follows: 2020-07-25 Andrew Burgess <andrew.burgess> PR fortran/23051 PR fortran/26139 * valops.c (value_ind): Pass address to readjust_indirect_value_type. * value.c (readjust_indirect_value_type): Make parameter non-const, and add extra address parameter. Resolve original type before using it. * value.h (readjust_indirect_value_type): Update function signature and comment.