Bug 1907014

Summary:	Review Request: rust-cty - Type aliases to C types like c_int for use with bindgen
Product:	[Fedora] Fedora	Reporter:	Nick Black <dank>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	RELEASE_PENDING ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nick Black 2020-12-12 10:43:41 UTC

Spec URL: https://nick-black.com/tabpower/fedora-rust/rust-cty.spec
SRPM URL: https://nick-black.com/tabpower/fedora-rust/rust-cty-0.2.1-1.fc32.src.rpm
Description: Type aliases to C types like c_int for use with bindgen
Fedora Account System Username: nickblack

Pretty much entirely rust2rpm boilerplate.

Comment 1 Fabio Valentini 2020-12-12 12:27:06 UTC

Please use the actual package Summary for the bug title.

Comment 2 Nick Black 2021-01-22 06:33:58 UTC

(In reply to Fabio Valentini from comment #1)
> Please use the actual package Summary for the bug title.

Updated, thanks.

Comment 3 Igor Raits 2021-01-22 08:44:39 UTC

The %license is missing, otherwise looks good.

Comment 4 Nick Black 2021-01-24 07:17:51 UTC

Thanks Igor, I've updated the spec and SRPM. I've also made the SRPM against f34 this time.

https://nick-black.com/tabpower/fedora-rust/rust-cty.spec
https://nick-black.com/tabpower/fedora-rust/rust-cty-0.2.1-1.fc34.src.rpm

PTAL

Comment 5 Igor Raits 2021-01-24 09:05:54 UTC

Hmm, does not seem so (or I am downloading file from the wrong link).

Comment 6 Nick Black 2021-01-24 09:20:12 UTC

Ugh, apologies, I copied the wrong version over. I've updated both the specfile and the derived SRPM.

Comment 7 Nick Black 2021-01-24 09:20:55 UTC

I've also updated the specfile and SRPM on #1907017 to include %license.

Comment 8 Robert-André Mauchin 🐧 2021-01-29 17:50:22 UTC

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 9 Nick Black 2021-01-30 04:25:59 UTC

Thanks! https://pagure.io/releng/fedora-scm-requests/issue/31962 requests the git module.

Comment 10 Mohan Boddu 2021-02-02 20:49:25 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cty