Bug 1907139

Summary:	HPP operator reports upgrade successful even though hostpath-provisioner pods are not upgraded
Product:	Container Native Virtualization (CNV)	Reporter:	Ruth Netser <rnetser>
Component:	Storage	Assignee:	Alexander Wels <awels>
Status:	CLOSED DUPLICATE	QA Contact:	Qixuan Wang <qixuan.wang>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	2.5.2	CC:	alitke, cnv-qe-bugs, ginger, ycui
Target Milestone:	---
Target Release:	2.5.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-14 14:17:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ruth Netser 2020-12-13 09:25:43 UTC

Description of problem:
Upgrade CNV 2.4.4 -> 2.5.2
Bug 1907138 led to hostpath-provisioner not being upgraded.
However, HPP operator reported in its conditions that everything is fine (available=true, degraded=false, progressing=false, upgradeable=true)

Version-Release number of selected component (if applicable):
CNV 2.4.4 - > CNV 2.5.2

How reproducible:
100% (seen on one cluster)


Steps to Reproduce:
1. Upgrade CNV 2.4.4 to CNV 2.5.2
2. When upgrade is reported as completed, check all CNV pods

Actual results:
CNV upgrade is reported as completed

Expected results:
HPP operator should not report its conditions that everything is ok but indicate that the pods failed to upgrade and progressing=true

Additional info:

Comment 1 Adam Litke 2020-12-14 14:15:52 UTC

I think there are two fixes needed:
1. Properly report upgrade failure when it occurs
2. Convert old useNamingPrefix string value to boolean automatically on upgrade

Comment 2 Adam Litke 2020-12-14 14:17:25 UTC

Marking this as a dupe of 1907138 since the issues are tightly related and will likely be fixed in a single PR.

Comment 3 Adam Litke 2020-12-14 14:17:40 UTC


*** This bug has been marked as a duplicate of bug 1907138 ***