Bug 1907766

Summary: fprintd-1.90.8-1.el8 fails to build with --nocheck
Product: Red Hat Enterprise Linux 8 Reporter: Kamil Dudka <kdudka>
Component: fprintdAssignee: Benjamin Berg <bberg>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: high    
Version: 8.4CC: bberg, kdudka, mkrajnak, tpelka
Target Milestone: rcKeywords: EasyFix, Patch, Regression, Triaged
Target Release: 8.4   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: fprintd-1.90.9-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:55:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kamil Dudka 2020-12-15 07:41:13 UTC 
Description of problem:
If `mock` or `rpmbuild` is invoked with `--nocheck`, fprintd fails to build.


Version-Release number of selected component (if applicable):
fprintd-1.90.8-1.el8


How reproducible:
Easily.


Steps to Reproduce:
1. koji download-build -a src fprintd-1.90.8-1.el8
2. mock -r rhel-8-x86_64 fprintd-1.90.8-1.el8 --nocheck


Actual results:
[...]
Processing files: fprintd-1.90.8-1.el8.x86_64
RPM build errors:
error: Could not open %files file /builddir/build/BUILD/fprintd-v1.90.8/fprintd.lang: No such file or directory


Expected results:
Successful build.


Additional info:
Introduced with the following dist-git commit:
http://pkgs.devel.redhat.com/cgit/rpms/fprintd/commit/?id=7a99a004

The following patch will fix it:
--- a/fprintd.spec
+++ b/fprintd.spec
@@ -69,17 +69,17 @@ fingerprint readers access.
 %install
 %meson_install
 mkdir -p $RPM_BUILD_ROOT/%{_localstatedir}/lib/fprint

 rm -f $RPM_BUILD_ROOT/%{_lib}/security/pam_fprintd.{a,la,so.*}

+%find_lang %{name}
+
 %check
 # The test suite will just throw errors due to missing dependencies

-%find_lang %{name}
-
 %postun pam
 if [ $1 -eq 0 ]; then
   /sbin/authconfig --disablefingerprint --update || :
 fi

 %files -f %{name}.lang
Comment 1 Benjamin Berg 2020-12-15 10:15:53 UTC 
Outch, bad bad mistake.
Comment 9 errata-xmlrpc 2021-05-18 15:55:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libfprint bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1889