Bug 1907890

Summary:	Misleading and incomplete alert message shown in pipeline-parameters and pipeline-resources form
Product:	OpenShift Container Platform	Reporter:	divgupta
Component:	Dev Console	Assignee:	divgupta
Status:	CLOSED ERRATA	QA Contact:	Karthik Jeeyar <kjeeyar>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.7	CC:	aos-bugs, kjeeyar, nmukherj
Target Milestone:	---
Target Release:	4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-24 15:44:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description divgupta 2020-12-15 13:10:19 UTC

Description of problem:
During FormFooter comp localization the comp was also refactored but other comps such as PipelineParametersForm and PipelineResourcesForm which are using FormFooter were not fixed accordingly by passing required labels to FormFooter comp to show correct alert message. Also the alert message is misleading as it asks to save the changes even though the save button is disabled.

How reproducible:
Always

Steps to Reproduce:
1.Create a pipeline
2.Go to pipeline details page
3.Click on parameters or resources tab
4.Click on +Add

Actual results:
Misleading and incomplete alert message is shown

Expected results:
Correct alert message with proper labels should be shown when save is enabled
`Click Save to save changes or Reload to cancel changes`

Additional info:
Pipeline operator should be installed

Comment 3 Karthik Jeeyar 2021-01-08 10:41:33 UTC

Verified on 
Build: 4.7.0-0.nightly-2021-01-07-181010
cluster: https://console-openshift-console.apps.dev-svc-4.7-010801.devcluster.openshift.com/k8s/ns/karthik/tekton.dev~v1beta1~Pipeline/nodejs-ex/resources
user: kubeadmin

Comment 5 errata-xmlrpc 2021-02-24 15:44:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633