Bug 1907907

Summary: avr-size --format=avr throws error
Product: [Fedora] Fedora Reporter: Charles Kirsch <kirsch352>
Component: avr-binutilsAssignee: Thibault North <thibault>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 33CC: giallu, kirsch352, mhlavink, thibault, trond.danielsen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: avr-binutils-2.35-3.fc33 avr-binutils-2.35-3.fc32 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-11 01:42:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fixed patch file none

Description Charles Kirsch 2020-12-15 13:53:33 UTC
Created attachment 1739338 [details]
Fixed patch file

Description of problem:
avr-size --format=avr is not working and throws error "avr-size: invalid argument to --format: avr"

Version-Release number of selected component (if applicable):
avr-binutils-2.35-1.fc33.x86_64

How reproducible:
always

Steps to Reproduce:
1. type avr-size --format=avr
2.
3.

Actual results:
avr-size: invalid argument to --format: avr
Usage: avr-size [option(s)] [file(s)]
 Displays the sizes of sections inside binary files
 If no input file(s) are specified, a.out is assumed
 The options are:
  -A|-B|-C|-G  --format={sysv|berkeley|avr|gnu}  Select output style (default is berkeley)
            --mcu=<avrmcu>            MCU name for AVR format only
  -o|-d|-x  --radix={8|10|16}         Display numbers in octal, decimal or hex
  -t        --totals                  Display the total sizes (Berkeley only)
            --common                  Display total size for *COM* syms
            --target=<bfdname>        Set the binary file format
            @<file>                   Read options from <file>
  -h        --help                    Display this information
  -v        --version                 Display the program's version

avr-size: supported targets: elf32-avr elf32-little elf32-big srec symbolsrec verilog tekhex binary ihex plugin


Expected results:
avr-size: 'a.out': No such file
(the same as for avr-size -C)

Additional info:
The fix is actually very easy. There is an error in the applied patch 30-binutils-2.20.1-avr-size.patch at line 300-301 (decode long-options):
Instead of:
+         case 'C':
+         case 'c':
It should be:
+         case 'A':
+         case 'a':
to match 1st character of --format option arg.

Comment 1 Fedora Update System 2021-02-02 20:05:57 UTC
FEDORA-2021-6ab5d52c9e has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6ab5d52c9e

Comment 2 Fedora Update System 2021-02-02 20:05:58 UTC
FEDORA-2021-d7dc6df821 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d7dc6df821

Comment 3 Fedora Update System 2021-02-03 01:31:24 UTC
FEDORA-2021-d7dc6df821 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-d7dc6df821`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d7dc6df821

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2021-02-03 02:30:17 UTC
FEDORA-2021-6ab5d52c9e has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-6ab5d52c9e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6ab5d52c9e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2021-02-11 01:42:54 UTC
FEDORA-2021-6ab5d52c9e has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2021-02-11 01:52:49 UTC
FEDORA-2021-d7dc6df821 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.