Bug 1908683

Summary: [machines] The VM memory is still 768 MB if only switch memory size to GB when creation
Product: Red Hat Enterprise Linux 8 Reporter: YunmingYang <yunyang>
Component: cockpit-appstreamAssignee: Simon Kobyda <skobyda>
Status: CLOSED ERRATA QA Contact: YunmingYang <yunyang>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.4CC: leiwang, mmarusak, mpitt, skobyda, wshi, xchen, ymao
Target Milestone: rc   
Target Release: 8.4   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:53:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description YunmingYang 2020-12-17 10:35:20 UTC 
Description of problem:
The VM memory is still 768 MB when creating a VM by "Import VM", using "Alpine Linux 3.8" for Operating system, and switch memory unit to "GB"(use default value of memory size, it should be 1)

Version-Release number of selected components (if applicable):
cockpit-machines-233.1-1.el8.noarch
cockpit-233.1-1.el8.x86_64
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

How reproducible:
100%

Steps to Reproduce:
1 Click button "Import VM"
2 Fill these fields as below
   Name: random string
   Installation Source: a path of the source disk(use cirros.qcow2 this time)
   Operating system: Alpine Linux 3.8
   Memory unit GB
3 Click "Import" button, then switch to the VM detail page

Actual results:
1 In step 2, after inputting "Operating system", the memory should be detected automatically, it should be 768 this time. Then the memory size should be 1 after switching memory unit to "GB"
2 After step 3, the memory on VM detail page is still 768 MB, not 1 GB

Expected results: 
1 After step 3, the memory on VM detail page should be 1 GB

Additional info:
Comment 1 Martin Pitt 2020-12-17 14:22:57 UTC 
Simon sent a fix upstream, thanks! https://github.com/cockpit-project/cockpit/pull/15059
Comment 4 YunmingYang 2021-01-13 09:29:02 UTC 
Test Versions:
cockpit-234-1.el8.x86_64
cockpit-machines-235-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

Test Steps:
1 Click button "Import VM"
2 Fill these fields as below
   Name: random string
   Installation Source: a path of the source disk(use cirros.qcow2 this time)
   Operating system: Alpine Linux 3.8
   Memory unit GB
3 Click "Import" button, then switch to the VM detail page

Test Results:
1 After step 3, the VM memory is 1 GB after going to the VM detail page 

According to the results, move the status to VERIFIED.
Comment 6 errata-xmlrpc 2021-05-18 15:53:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-appstream bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1875