Bug 1909093

Summary: [MTC-UI] Some Backups are reported as failed in the UI even if they were successfully executed
Product: Migration Toolkit for Containers Reporter: Sergio <sregidor>
Component: UIAssignee: Pranav Gaikwad <pgaikwad>
Status: CLOSED ERRATA QA Contact: Xin jiang <xjiang>
Severity: medium Docs Contact: Avital Pinnick <apinnick>
Priority: unspecified    
Version: 1.4.0CC: chezhang, ernelson, pgaikwad, rjohnson, rpattath, whu, xjiang
Target Milestone: ---   
Target Release: 1.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-11 12:54:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot none

Description Sergio 2020-12-18 10:47:51 UTC
Created attachment 1740202 [details]
screenshot

Description of problem:
Depending on the  backup's name some backups are reported as failed even when they were executed successfully.

Version-Release number of selected component (if applicable):
MTC 1.4.0

How reproducible:
Always

Steps to Reproduce:
1. Create a namespace with this name

$ oc new-project ocp-37723-partialfailbackup

2.In source cluster. Build an image

$ oc new-build -D $'FROM centos:7\nRUN yum install -y httpd' -n ocp-37722-partialfailrestore


3. Create a migration plan for this namespace. Indirect Image Migtration.

Use this name for the migplan "ocp-37722-partialfailrestore-migplan-1608223008"

4. Execute the migration



Actual results:
The migmigration resource will report the Backup as successfully executed, but the UI will show the Backup in the Backup phase as failed (in red and with an 'X' symbol)

Expected results:
The backup should be displayed in the UI as a successfully executed Backup (in green and without the 'X')

Additional info:

this is the full migmigration yaml file

$ oc get migmigration -o yaml 
apiVersion: v1
items:
- apiVersion: migration.openshift.io/v1alpha1
  kind: MigMigration
  metadata:
    annotations:
      openshift.io/touch: 68f96031-4086-11eb-8182-0a580a83000b
    creationTimestamp: "2020-12-17T16:37:03Z"
    generation: 42
    labels:
      controller-tools.k8s.io: "1.0"
      migration.openshift.io/migplan-name: ocp-37722-partialfailrestore-migplan-1608223008
    managedFields:
    - apiVersion: migration.openshift.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        f:metadata:
          f:labels:
            .: {}
            f:controller-tools.k8s.io: {}
        f:spec:
          .: {}
          f:migPlanRef:
            .: {}
            f:name: {}
            f:namespace: {}
          f:stage: {}
      manager: OpenAPI-Generator
      operation: Update
      time: "2020-12-17T16:37:03Z"
    - apiVersion: migration.openshift.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        f:metadata:
          f:annotations:
            .: {}
            f:openshift.io/touch: {}
          f:labels:
            f:migration.openshift.io/migplan-name: {}
          f:ownerReferences:
            .: {}
            k:{"uid":"46d9aeb4-39ec-4bc0-af55-addc4786316e"}:
              .: {}
              f:apiVersion: {}
              f:kind: {}
              f:name: {}
              f:uid: {}
        f:status:
          .: {}
          f:conditions: {}
          f:itinerary: {}
          f:observedDigest: {}
          f:phase: {}
          f:pipeline: {}
          f:startTimestamp: {}
      manager: manager
      operation: Update
      time: "2020-12-17T16:39:19Z"
    name: ocp-37722-partialfailrestore-mig-1608223008
    namespace: openshift-migration
    ownerReferences:
    - apiVersion: migration.openshift.io/v1alpha1
      kind: MigPlan
      name: ocp-37722-partialfailrestore-migplan-1608223008
      uid: 46d9aeb4-39ec-4bc0-af55-addc4786316e
    resourceVersion: "693128"
    selfLink: /apis/migration.openshift.io/v1alpha1/namespaces/openshift-migration/migmigrations/ocp-37722-partialfailrestore-mig-1608223008
    uid: 72b302ee-3c1b-4820-992a-ca5b1a6ecae4
  spec:
    migPlanRef:
      name: ocp-37722-partialfailrestore-migplan-1608223008
      namespace: openshift-migration
    stage: false
  status:
    conditions:
    - category: Advisory
      durable: true
      lastTransitionTime: "2020-12-17T16:39:19Z"
      message: The migration has completed successfully.
      reason: Completed
      status: "True"
      type: Succeeded
    itinerary: Final
    observedDigest: ec55c01c7a550820c2930af61b61eb1699219722979ef13590a01438481db4d2
    phase: Completed
    pipeline:
    - completed: "2020-12-17T16:37:46Z"
      message: Completed
      name: Prepare
      started: "2020-12-17T16:37:03Z"
    - completed: "2020-12-17T16:38:05Z"
      message: Completed
      name: Backup
      progress:
      - 'Backup openshift-migration/ocp-37722-partialfailrestore-mig-1608223008-f5dgr:
        37 out of estimated total of 37 objects backed up (16s)'
      started: "2020-12-17T16:37:46Z"
    - completed: "2020-12-17T16:38:57Z"
      message: Completed
      name: StageBackup
      progress:
      - 'Backup openshift-migration/ocp-37722-partialfailrestore-mig-1608223008-k5ps2:
        2 out of estimated total of 2 objects backed up (11s)'
      started: "2020-12-17T16:38:05Z"
    - completed: "2020-12-17T16:39:05Z"
      message: Completed
      name: StageRestore
      progress:
      - 'Restore openshift-migration/ocp-37722-partialfailrestore-mig-1608223008-z4s72:
        Completed'
      started: "2020-12-17T16:38:57Z"
    - message: Skipped
      name: DirectImage
      skipped: true
    - message: Skipped
      name: DirectVolume
      skipped: true
    - completed: "2020-12-17T16:39:17Z"
      message: Completed
      name: Restore
      progress:
      - 'Restore openshift-migration/ocp-37722-partialfailrestore-mig-1608223008-z8slb:
        Completed'
      started: "2020-12-17T16:39:05Z"
    - completed: "2020-12-17T16:39:19Z"
      message: Completed
      name: Cleanup
      started: "2020-12-17T16:39:17Z"
    startTimestamp: "2020-12-17T16:37:03Z"
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

Comment 6 Sergio 2021-01-11 12:29:30 UTC
Verified using MTC 1.4.0

openshift-migration-rhel7-operator@sha256:60a0bdc7fca0d3d597efae0c242f7dc25da45c072b33198c3eb7fa425a604472

    - name: MIG_UI_REPO
      value: openshift-migration-ui-rhel8@sha256
    - name: MIG_UI_TAG
      value: fd41dd77250c8dfe068263bdc0f1b9a05b2355ca3c163a998794a75f33523627


The UI does not display successful backups as failed any more.

Moved to VERIFIED status.

Comment 8 errata-xmlrpc 2021-02-11 12:54:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5329