Bug 1909197

Summary: [CBT] Enable incremental backup by default for new installation
Product: [oVirt] ovirt-engine Reporter: Yury.Panchenko
Component: Backup-Restore.VMsAssignee: Eyal Shenitzky <eshenitz>
Status: CLOSED CURRENTRELEASE QA Contact: Ilan Zuckerman <izuckerm>
Severity: high Docs Contact: bugs <bugs>
Priority: unspecified    
Version: 4.4.3.12CC: bugs, dfodor, eshenitz, izuckerm, michal.skrivanek, nsoffer, pchavva, sfishbai
Target Milestone: ovirt-4.4.5Flags: izuckerm: testing_plan_complete+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Feature: Incremental backup enabled by default for 4.5 clusters. Reason: Allow using the incremental backup feature without any explicit database configuration operations Result: For 4.5 clusters, incremental backup can be used without changing the "IsIncrementalBackupSupported" configuration value in the database.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-18 15:15:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1799015    
Bug Blocks:    

Description Yury.Panchenko 2020-12-18 15:08:25 UTC
Description of problem:
Now users can't use incremental backup on KVM by default.
To enable this, customer need perform additional action as listed in documentation.
https://www.ovirt.org/develop/release-management/features/storage/incremental-backup.html

> Support incremental backup. Currently only full backup for raw and qcow2 disks is supported, to enable support for incremental backup (work in progress), Engine config value ‘IsIncrementalBackupSupported’ must be set to ‘true’.
> # engine-config -s "IsIncrementalBackupSupported=true"
> # systemctl restart ovirt-engine 

This feature is always required for backup software.
So, can this feature be enabled by default?

Version-Release number of selected component (if applicable):
ovirt-4.4.3

Actual results:
incremental backup not working on new installation

Expected results:
incremental backup not working on new installation

Comment 2 Eyal Shenitzky 2020-12-22 12:42:34 UTC
At this point, Libvirt still doesn't fully support incremental backup and it is still considered a technological preview.
When libvirt will fully support it we can do the same.

Comment 3 Eyal Shenitzky 2020-12-22 12:46:57 UTC
I am currently setting it to 4.4.6 since libvirt should support it at RHEL-8.4.0 which is expected to arrive around that version.

Comment 4 Yury.Panchenko 2021-01-04 13:40:27 UTC
> At this point, Libvirt still doesn't fully support incremental backup and it is still considered a technological preview.
> When libvirt will fully support it we can do the same.

Probably, enable this service by default not cause any risks. To use them, customer need special API call, if you place "experimental functional" alert in documentation this will more than enough.

But, this service required for any new backup products.

Comment 5 Eyal Shenitzky 2021-01-10 12:00:49 UTC
The special API call added for raising the user awareness that he choose to use a feature
that is still in the technological-preview phase.
Since this feature handles VMs backups we want the user to be fully aware of that fact.

The feature will be enabled by default once it is fully supported by all the other
layers of the product and after it will be fully tested and covered.

Comment 6 Ilan Zuckerman 2021-03-08 11:57:30 UTC
Verified on  RHV build name: rhv-4.4.5-7

After re-deployment of the engine (clean install) + provision with all of the basic assets, the 4.5 cluster has incremental backup feature enabled by default.

[root@storage-ge-3 ~]# engine-config -g "IsIncrementalBackupSupported"
IsIncrementalBackupSupported: false version: 4.2
IsIncrementalBackupSupported: false version: 4.3
IsIncrementalBackupSupported: false version: 4.4
IsIncrementalBackupSupported: true version: 4.5

Comment 7 Sandro Bonazzola 2021-03-18 15:15:52 UTC
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 8 Sandro Bonazzola 2021-03-22 12:55:43 UTC
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.