Bug 1909400

Summary:	Review Request: python-setuptools_git_ls_files - Plugin for setuptools that finds all git tracked files
Product:	[Fedora] Fedora	Reporter:	Ben Beasley <code>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-05 23:25:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ben Beasley 2020-12-19 16:55:25 UTC

Spec URL: https://gitlab.com/musicinmybrain/setuptools_git_ls_files-rpm-packaging/-/raw/9efc29f32fb0749915f1e327a84970dccf50ad52/python-setuptools_git_ls_files.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5961/57805961/python-setuptools_git_ls_files-0.1.2-1.fc34.src.rpm

Description:

A plugin for setuptools that finds all git tracked files, including submodules.
The command used is git ls-files --cached --recurse-submodule.

Fedora Account System Username: music

Koji builds:

F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=57805949
F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=57805950

I intend to backport to EPEL7–8, but this will require a forked spec file that does not use the pyproject-rpm-macros. I prefer to keep the Fedora spec clean.

This is a dependency for python-cffsubr, to be packaged subsequently.

Comment 1 Ben Beasley 2021-01-03 17:59:45 UTC

Note that this is an extremely trivial, almost minimal, Python package.

Comment 2 Ben Beasley 2021-01-31 15:00:49 UTC

Okay, I am going to use conditionals on this one to support all EPEL and Fedora releases after all.

Updated spec URL: https://gitlab.com/musicinmybrain/fedora-rpm/-/raw/49f6081edcdf35dbb68ea59009e38d7bc108a0e8/python-setuptools_git_ls_files.spec
Updated SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3904/60973904/python-setuptools_git_ls_files-0.1.2-5.fc34.src.rpm

Koji builds:

F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=60973903
F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=60973984
F32: https://koji.fedoraproject.org/koji/taskinfo?taskID=60973985
EL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=60973988
EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=60973989

Comment 3 Ben Beasley 2021-02-02 15:30:30 UTC

Fixed an issue with the EPEL7 files list:

Updated spec URL: https://gitlab.com/musicinmybrain/fedora-rpm/-/raw/d227b8a6559d277985bb616656746f684f38c4a8/python-setuptools_git_ls_files.spec
Updated SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9751/61129751/python-setuptools_git_ls_files-0.1.2-6.fc34.src.rpm

Koji builds:

F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=61129749
F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=61129983
F32: https://koji.fedoraproject.org/koji/taskinfo?taskID=61130368
EL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=61130720
EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=61131010

Comment 4 Ben Beasley 2021-03-02 14:28:44 UTC

I may close this review request; see https://bugzilla.redhat.com/show_bug.cgi?id=1928694. For now, if you were thinking of reviewing this package, please consider https://bugzilla.redhat.com/show_bug.cgi?id=1911928 instead.

Comment 5 Ben Beasley 2021-03-05 23:25:59 UTC

The specific need for this package has been worked around, and it is of limited general usefulness, so I am closing this review request.