Bug 1910353

Summary: Snapshot migrations are creating rsync pods
Product: Migration Toolkit for Containers Reporter: Sergio <sregidor>
Component: GeneralAssignee: Dylan Murray <dymurray>
Status: CLOSED ERRATA QA Contact: Xin jiang <xjiang>
Severity: medium Docs Contact: Avital Pinnick <apinnick>
Priority: medium    
Version: 1.4.0CC: chezhang, dymurray, ernelson, rjohnson, rpattath, whu, xjiang
Target Milestone: ---   
Target Release: 1.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-11 12:55:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sergio 2020-12-23 14:54:22 UTC 
Description of problem:
When we execute a migration where all volumes are migrated using snapshot copy, the rsync pods are being created anyway.
 

Version-Release number of selected component (if applicable):
MTC 1.4.0
SOURCE CLUSTER: Azure 4.3
TARGET CLUSTER: Azure 4.7
REPLICATION REPOSITORY: Azure storage class


How reproducible:
Always

Steps to Reproduce:
1. Create an application with one PVC

oc new-project bztest
oc new-app cakephp-mysql-persistent

(if there are problems deploying cakephp-mysql-persistent, try using django-psql-persistent instead)

2. Create a migration plan with direct volume migration and direct image migration. Use Snapshot as copy method.

3. Execute the migration plan


Actual results:
In the migrated namespaces check the events see that rsync pods are being created
$ oc get events -n ocp-cakephp  | grep rsync
27m         Normal    Scheduled                     pod/directvolumemigration-rsync-transfer           Successfully assigned ocp-cakephp/directvolumemigration-rsync-transfer to sregidor-tgt-az474-gcmdl-worker-northcentralus-1
26m         Normal    SuccessfulAttachVolume        pod/directvolumemigration-rsync-transfer           AttachVolume.Attach succeeded for volume "pvc-0e11bb2d-f3fe-4d81-9e6f-065c9746bceb"
26m         Normal    AddedInterface                pod/directvolumemigration-rsync-transfer           Add eth0 [10.131.0.22/23]
26m         Normal    Pulled                        pod/directvolumemigration-rsync-transfer           Container image "registry.redhat.io/rhmtc/openshift-migration-rsync-transfer-rhel8@sha256:715d6869c6d23d572808d64c511b94c6af07a6bce08b4f62a78542b61f3af02a" already present on machine



Expected results:
A migration running only snapshot migrations should not create rsync pods.

Additional info:
Indirect migrations do not create stage pods.
Comment 1 Dylan Murray 2021-01-05 17:14:32 UTC 
https://github.com/konveyor/mig-controller/pull/873
Comment 6 Xin jiang 2021-01-11 13:35:37 UTC 
Verified.

"registry.redhat.io/rhmtc/openshift-migration-controller-rhel8@sha256:6f53fa6c8ea2648736ced2d38ebb2ead46d3975f71d7efe4bd24e6fec223aaee",
Comment 7 Sergio 2021-01-11 14:04:25 UTC 
Verified using MCT 1.4.0

openshift-migration-rhel7-operator@sha256:60a0bdc7fca0d3d597efae0c242f7dc25da45c072b33198c3eb7fa425a604472
    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: 6f53fa6c8ea2648736ced2d38ebb2ead46d3975f71d7efe4bd24e6fec223aaee

Verified in Azure: 4.3 -> 4.7. The snapshot migration finished OK and no rsync pod was created.

Moved to VERIFIED status.
Comment 9 errata-xmlrpc 2021-02-11 12:55:27 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5329