Bug 1910753

Summary: Support Directory Path to Devfile
Product: OpenShift Container Platform Reporter: Mohammed Saud <msaud>
Component: Dev ConsoleAssignee: Mohammed Saud <msaud>
Status: CLOSED ERRATA QA Contact: Aritra Roy <ariroy>
Severity: medium Docs Contact:
Priority: high    
Version: 4.7CC: aballant, aos-bugs, ariroy, nmukherj
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-24 15:48:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mohammed Saud 2020-12-24 12:37:46 UTC
Description of problem:
When using the UI to select a directory path for the git, it fails to take this into account when we go searching for the Devfile. git-service package needs to support the parameter for directory in order to find the correct file location.


Prerequisites (if any, like setup, operators/versions):
None


Steps to Reproduce
    Go to the Import from Devfile add flow
    Use a git repo that has the devfile.yaml not at the root of the repo (ie https://github.com/maysunfaisal/node-bulletin-board-5)
    Update the git adv option for directory to be the path to the devfile.yaml (in the example above, `app`)


Actual results:
Fails to detect the devfile.yaml and does not update to find it even if the directory is accurate


Expected results:
To update to find the Devfile. We need to make sure we don't rate limit ourselves as well so debounce the go find the devfile.yaml call either in the git-service or in the GitSection hook.


Reproducibility (Always/Intermittent/Only Once):
Always


Build Details:
4.7.0-0.nightly-2020-12-18-031435


Additional info:
    The sample has the devfile.yaml at the root and not suitable for this test.
    We do not need to support different named Devfiles, keep the constant for 4.7

Comment 3 Aritra Roy 2021-01-27 10:32:33 UTC
verified on build 4.7.0-0.nightly-2021-01-26-162323

Comment 6 errata-xmlrpc 2021-02-24 15:48:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633