Bug 1910860

Summary: Review Request: golang-github-cheggaaa-pb - Console progress bar for Golang
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review, quantum.analyst
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-17 00:45:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449, 1910865, 1922806    

Description Fabian Affolter 2020-12-25 09:16:59 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-cheggaaa-pb.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-cheggaaa-pb-3.0.5-1.fc33.src.rpm

Project URL: https://github.com/cheggaaa/pb

Description:
Console progress bar for Golang.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=58248788

rpmlint output:
$ rpmlint golang-github-cheggaaa-pb-3.0.5-1.fc33.src.rpm 
golang-github-cheggaaa-pb.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint golang-github-cheggaaa-pb-devel-3.0.5-1.fc33.noarch.rpm 
golang-github-cheggaaa-pb-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/cheggaaa/pb/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab
Comment 1 Elliott Sales de Andrade 2021-01-24 21:11:06 UTC 
If you want v3, this should be named golang-github-cheggaaa-pb-3, and you should use github.com/cheggaaa/pb/v3 as import path.
Comment 2 Robert-André Mauchin 🐧 2021-03-08 09:16:28 UTC 
(In reply to Elliott Sales de Andrade from comment #1)
> If you want v3, this should be named golang-github-cheggaaa-pb-3, and you
> should use github.com/cheggaaa/pb/v3 as import path.

This but also, due to how this package is made, with a v3 subdirectory, you should do something like this in %prep:

# https://github.com/cheggaaa/pb
%global goipath         github.com/cheggaaa/pb/v3
%global forgeurl        https://github.com/cheggaaa/pb

[…]

%prep
%goprep
rm *.go && mv v3/* ./


Otherwise it could create conflicts if a dependency chain both depend on v1 and v3. This way we have the correct import path (github.com/cheggaaa/pb/v3) and the correct location for the .goipath file.

Needinfo me for review once fixed.
Comment 3 Robert-André Mauchin 🐧 2021-03-09 12:02:20 UTC 
Actually I needed it too and sent a Review Request too.
You can see my SPEC here: https://eclipseo.fedorapeople.org/for-review/golang-github-cheggaaa-pb-3.spec
Comment 4 Robert-André Mauchin 🐧 2021-03-09 12:02:27 UTC 
*** Bug 1922793 has been marked as a duplicate of this bug. ***
Comment 5 Robert-André Mauchin 🐧 2021-03-17 15:27:36 UTC 
Still interested in this review?
Comment 6 Package Review 2021-04-17 00:45:15 UTC 
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.