Bug 1910991
| Summary: | Review Request: PyQt-builder - The PEP 517 compliant PyQt build system | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-12-31 22:19:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kevin Fenzi
2020-12-26 20:05:06 UTC
The license of the package is correct and appropriated for Fedora. The spec file is simple and correct. My main issue is with the dlls bundle. What is the license of those files? Are those the preferred way to build them... Do we need them in linux and in Fedora in particular? Good question. Those dll files are for pyqt-bundler which allows someone to bundle os stuff in their windows binary. Some of them are openssl, and some of them are microsoft visual basic (redistributable). They aren't made from source, and I don't think too many people will be using this package on linux to build and bundle windows binaries, so I am fine with just dropping them. I did look and opensuse ships them. Debian doesn't seem to package pyqt-builder at all, so no help there. New version, with dlls removed: Spec URL: https://scrye.com/~kevin/fedora/review/PyQt-builder/PyQt-builder.spec SRPM URL: https://scrye.com/~kevin/fedora/review/PyQt-builder/PyQt-builder-1.6.0-2.fc34.src.rpm (In reply to Kevin Fenzi from comment #2) > Good question. Those dll files are for pyqt-bundler which allows someone to > bundle os stuff in their windows binary. Some of them are openssl, and some > of them are microsoft visual basic (redistributable). They aren't made from > source, and I don't think too many people will be using this package on > linux to build and bundle windows binaries, so I am fine with just dropping > them. > > I did look and opensuse ships them. Debian doesn't seem to package > pyqt-builder at all, so no help there. > > New version, with dlls removed: > > Spec URL: > https://scrye.com/~kevin/fedora/review/PyQt-builder/PyQt-builder.spec > SRPM URL: > https://scrye.com/~kevin/fedora/review/PyQt-builder/PyQt-builder-1.6.0-2. > fc34.src.rpm My view point was from the license angle, at most that status should have been declared in the spec file. :-) Something like BSD and Redistributable or something equivalent. Honestly I trust your judgement here. :-) The package is approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/PyQt-builder Built in rawhide. |