Bug 191110

Summary:	Review Request: perl-Devel-Cover - Code coverage metrics for Perl
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-05-12 18:06:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Jose Pedro Oliveira 2006-05-08 22:39:58 UTC

Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Devel-Cover.spec

SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Devel-Cover-0.55-1.src.rpm

Description:
This module provides code coverage metrics for Perl.


Targets: distros >= FC-5

Comment 1 Jason Tibbitts 2006-05-12 04:16:36 UTC

rpmlint complains:

W: perl-Devel-Cover doc-file-dependency
/usr/share/doc/perl-Devel-Cover-0.55/buildperl perl(lib)

The buildperl script probably shouldn't be executable.

Makefile.PL warns:
Devel::Cover 0.55 has not been tested with perl 5.008008.
but the test suite seems fine.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
follows the Perl specfile template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   6bb9ddcd7a9e4d87c02b8bbea7ad3c4a  Devel-Cover-0.55.tar.gz
   6bb9ddcd7a9e4d87c02b8bbea7ad3c4a  Devel-Cover-0.55.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
X rpmlint is silent.
* final provides and requires are sane.
O shared libraries are present, but they are internal to Perl so ldconfig
doesn't need to be called.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=38, Tests=38, 72 wallclock secs (69.46 cusr +  2.87 csys = 72.33 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 2 Jose Pedro Oliveira 2006-05-12 10:49:38 UTC

(In reply to comment #1)
> rpmlint complains:
> 
> W: perl-Devel-Cover doc-file-dependency
> /usr/share/doc/perl-Devel-Cover-0.55/buildperl perl(lib)
> 
> The buildperl script probably shouldn't be executable.

Oops! Corrected in:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Devel-Cover-0.55-2.src.rpm
(specfile link: the previous one)

Comment 3 Jason Tibbitts 2006-05-12 16:02:05 UTC

The new package builds fine and the permissions problem is fixed.

APPROVED

Comment 4 Jose Pedro Oliveira 2006-05-12 18:06:36 UTC

Thanks for the review.

Imported and built for FC-5 and devel.