Bug 1912419

Summary:	Review Request: python-asyncwhois - Python module for performing WHOIS queries
Product:	[Fedora] Fedora	Reporter:	Fabian Affolter <mail>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	code, eclipseo, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-01 00:45:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449, 563471

Description Fabian Affolter 2021-01-04 12:15:50 UTC

Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-asyncwhois.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-asyncwhois-0.2.0-1.fc33.src.rpm

Project URL: https://github.com/pogzyb/asyncwhois

Description:
Python module for performing WHOIS queries for any domain.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=58908646

rpmlint output:
$ rpmlint python-asyncwhois-0.2.0-1.fc33.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python3-asyncwhois-0.2.0-1.fc33.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab

Comment 1 Ben Beasley 2021-01-15 16:58:41 UTC

Before a full review, would you mind taking care of these?

- The %python_provide macro is obsolete, and you do not even need %py_provides if you are not packaging for Fedora 32. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro (Somebody really needs to update pyp2rpm to match the current guidelines; the same things keep coming up over and over.)
- A new version 0.2.2 is available.
- You can use the GitHub tarball and run the tests, because your issue https://github.com/pogzyb/asyncwhois/issues/10 is now fixed. You’ll need to add the install_requires as BR’s.
- Upstream added the separate license file in https://github.com/pogzyb/asyncwhois/pull/11, too.

This is not mandatory, but please consider whether you might want to use the pyproject-rpm-macros (https://src.fedoraproject.org/rpms/pyproject-rpm-macros). Generated BR’s are really nice; you get the version requirements from upstream if applicable, and you’ll never forget to update them. In https://bugzilla.redhat.com/show_bug.cgi?id=1914450, I provided an example of rewriting a simple spec file to use the pyproject-rpm-macros. In this case, you would use “%pyproject_buildrequires -r” to get the install_requires as BR’s, and ”%pytest” in %check, adding a manual BR on python3dist(pytest).

By the way, if you need to use a GitHub tarball, the %forgemeta macro is really helpful, *especially* if releases are not properly tagged. See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ for examples.

Comment 2 Ben Beasley 2021-05-31 13:30:41 UTC

Are you still working on this?

Comment 3 Package Review 2021-07-01 00:45:34 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.