Bug 1912908

Summary: Allow using "scsi" bus for disks in template validation
Product: Container Native Virtualization (CNV) Reporter: Fabien Dupont <fdupont>
Component: SSPAssignee: Karel Šimon <ksimon>
Status: CLOSED WONTFIX QA Contact: Ilanit Stein <istein>
Severity: high Docs Contact:
Priority: unspecified    
Version: 2.5.0CC: amastbau, cnv-qe-bugs, dagur, fdeutsch, ipinto, istein, ksimon, kwiesmul, oyahud, rnetser
Target Milestone: ---   
Target Release: 2.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kubevirt-ssp-operator-container-v2.6.0-33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-10 11:22:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1903585    

Description Fabien Dupont 2021-01-05 15:05:15 UTC
Description of problem:
When VMIO migrates a VM from RHV, it needs to be able to set the disk bus to "scsi" when the source VM is using "virtio_scsi". Currently, the template validation webhook refuses the VM and the following error is returned:

"DataVolumeCreationFailed: Error while importing disk image: . admission webhook "virt-template-admission.kubevirt.io" denied the request: virto disk bus type has better performance, install virtio drivers in VM and change bus type: Some of [scsi] are not in [virtio], disk bus has to be either virtio or sata: Some of [scsi] are not in [virtio, sata]".

Version-Release number of selected component (if applicable): 2.5.2


How reproducible: Always

Comment 1 Ruth Netser 2021-01-06 12:18:12 UTC
Daniel, we would like to target this to 2.6. Will you have the capacity to verify it from V2V side?

Comment 2 Daniel Gur 2021-01-06 12:54:08 UTC
It should  be aligned with  https://bugzilla.redhat.com/show_bug.cgi?id=1903585
We will be able to verify yes

Comment 3 Amos Mastbaum 2021-01-21 11:31:49 UTC
Verification is Blocked by a vmimport crashloopback issue:

[amastbau@amastbau totp2]$ oc logs pods/importer-win20191-9de75658-e59b-48db-b7ac-06e79087e98c --follow
I0121 10:06:22.930567       1 importer.go:52] Starting importer
I0121 10:06:22.931242       1 importer.go:121] begin import process
E0121 10:06:24.833751       1 importer.go:137] Fault reason is "Operation Failed". Fault detail is "[Cannot transfer Virtual Disk. The relevant Storage Domain's status is Unknown.]". HTTP response code is "409". HTTP response message is "409 Conflict".
Error sending transfer image request
kubevirt.io/containerized-data-importer/pkg/importer.getTransfer
	/remote-source/app/pkg/importer/imageio-datasource.go:272
kubevirt.io/containerized-data-importer/pkg/importer.createImageioReader
	/remote-source/app/pkg/importer/imageio-datasource.go:184
kubevirt.io/containerized-data-importer/pkg/importer.NewImageioDataSource
	/remote-source/app/pkg/importer/imageio-datasource.go:60
main.main
	/remote-source/app/cmd/cdi-importer/importer.go:135
runtime.main
	/usr/lib/golang/src/runtime/proc.go:203
runtime.goexit
	/usr/lib/golang/src/runtime/asm_amd64.s:1373
[amastbau@amastbau totp2]

will link to BZ once opened

Comment 6 errata-xmlrpc 2021-03-10 11:22:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 2.6.0 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:0799

Comment 7 Ilanit Stein 2021-03-18 09:25:28 UTC
@Karel,

Can this bug be cloned to 2.5.z? 

Thanks.

Comment 8 Karel Šimon 2021-03-24 06:40:38 UTC
It should be technically possible. But I need approve from Kevin or Fabian.

Comment 9 Fabian Deutsch 2021-03-24 08:10:03 UTC
@istein what is the justification for the backport to 2.5.z?

Comment 10 Ilanit Stein 2021-03-25 13:15:55 UTC
The request to backport this bug to 2.5.z was to allow backporting the v2v bug 1903585, that depends on it.
But, I am withdrawing my request since the PM (Miguel Perez Colino) decided to offer update to CNV-2.6, 
in case the fix for the v2v bug 1903585 is needed.

Comment 11 Fabian Deutsch 2021-03-25 14:09:08 UTC
Thanks Ilanit.

There for no backport is needed.

Comment 12 Red Hat Bugzilla 2023-09-15 00:57:43 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days