Bug 191389
| Summary: | Review Request: oooqs2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> | ||||
| Component: | Package Review | Assignee: | Michael J Knox <michael> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | andy, gauret | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-09-22 02:40:39 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Dennis Gilmore
2006-05-11 15:28:05 UTC
Created attachment 130394 [details]
desktop russian translation patch
I've translate desktop entry to Russian. Please, include attached patch in the package. P.S. It's not review, just addon. And just a note: why do you requires openoffice.org-* instead of only -core? If I don't want to install the -writer (for example) and I should like to use oooqs2 with installed -calc only the oooqs2 installed me all monster office. It's no good solution as I think. The reason i require all the components of openoffice.org was because the applet provides shortcuts for each of the different components and if someone wanted to start oowriter from the applet and it did not work they would be surprised Hey.. I will review this package.. ---------------------------------------- Review for release 1: * RPM name is OK * Source oooqs2-1.0.tar.gz is the same as upstream * Builds fine in mock * File list looks OK Needs work: * BuildRequires: desktop-file-utils is missing * rpmlint: need to fix symlink warnings * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets) * Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets) Notes: You fix up the %post/%postun scriplets, the is a COPYING file and it should be included in the %docs rpmlint of oooqs2: W: oooqs2 dangling-symlink /usr/share/doc/HTML/de/oooqs2/common /usr/share/doc/HTML/de/common W: oooqs2 symlink-should-be-relative /usr/share/doc/HTML/de/oooqs2/common /usr/share/doc/HTML/de/common W: oooqs2 dangling-symlink /usr/share/doc/HTML/en/oooqs2/common /usr/share/doc/HTML/en/common W: oooqs2 symlink-should-be-relative /usr/share/doc/HTML/en/oooqs2/common /usr/share/doc/HTML/en/common As commented in the kmobiletools review, you will not need to add the gtk cruff to your spec. SPEC URL: http://ausil.us/packages/oooqs2.spec SRPM URL: http://ausil.us/packages/oooqs2-1.0-2.fc5.src.rpm added the COPYING File added the patch for Russian desktop file translation the dangling symlinks cant fix the files they point to are provided by kdelibs and the language packs this is extremely common in kde packages. the relative symlinks are fixed Looks good. APPROVED. Please remember to close this review request once inmported into CVS and built. This package was imported, but doesn't seem to have been built yet. Is there a issue with the build? ppc build failed and i havent had a chance to work out why yet. ok built on all arches now :) |