Bug 1913941

Summary: pkix_Build_GatherCerts() bug causes sporadic libreswan/IKE certificate validation errors
Product: Red Hat Enterprise Linux 8 Reporter: Paul Wouters <pwouters>
Component: nssAssignee: nss-nspr-maint <nss-nspr-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Ivan Nikolchev <inikolch>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 8.3CC: inikolch, paul.wouters, rrelyea, ssorce
Target Milestone: rcKeywords: Triaged, ZStream
Target Release: 8.0Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1976250 (view as bug list) Environment:
Last Closed: 2021-12-16 11:54:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1976250    

Description Paul Wouters 2021-01-07 20:04:08 UTC 
Description of problem:

See https://bugzilla.mozilla.org/show_bug.cgi?id=1682044


pkix_Build_GatherCerts() + pkix_CacheCert_Add() can corrupt "cachedCertTable"


pkix_Build_GatherCerts() has two code paths for creating the list "certsFound":

    pkix_CacheCert_Lookup()
    this sets "certsFound" to a new list
    "certsFound" and "cachedCertTable" share items but not the list

    pkix_CacheCert_Add(pkix_pl_Pk11CertStore_CertQuery())
    this sets "certsFound" to a new list; and then adds the list to "cachedCertTable"
    "certsFound" and "cachedCertTable" share a linked list

Because the latter doesn't create a separate list, deleting list elements from "certsFound" can also delete list elements from within "cacheCertTable". And if this happens while pkix_CacheCert_Lookup() is trying to update the same element's reference, a core dump can result.
Comment 2 Bob Relyea 2021-05-12 16:12:12 UTC 
upstream patch will be picked up in the rebase.
Comment 4 Bob Relyea 2021-06-23 21:46:39 UTC 
Need zstream+ to attach to the errrata.