Bug 1914192

Summary:	Please update ddclient to 3.9.1 in EPEL7
Product:	[Fedora] Fedora EPEL	Reporter:	Nick <nick>
Component:	ddclient	Assignee:	Scott Talbert <swt>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	epel7	CC:	i, jrowens.fedora, swt, thomas, trpost
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	ddclient-3.9.1-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-01-25 01:35:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nick 2021-01-08 10:26:18 UTC

Description of problem:
EPEL7 needs to be updated to ddclient-3.9.1 in line with EPEL8 as the API for Cloudflare changed a while ago and is not supported by ddclient-3.8.3-2. It works with 3.9.1


Version-Release number of selected component (if applicable): 3.8.3-2


How reproducible: 100%


Steps to Reproduce:
1.Set up 3.8.3-2 to update a Cloudflare FQDN and force an update:
2.ddclient -daemon=0 -debug -verbose -noquiet
3.

Actual results:
The update fails. Depending on how you try, you either get no message but no update appears in the Cloudflare dashboard, or you may get different error messages.

Expected results:
The IP for the selected FQDN should change at Cloudflare.

Additional info:

Comment 1 Fedora Update System 2021-01-09 03:10:05 UTC

FEDORA-EPEL-2021-44377d8bc7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-44377d8bc7

Comment 2 Fedora Update System 2021-01-10 01:45:59 UTC

FEDORA-EPEL-2021-44377d8bc7 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-44377d8bc7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Nick 2021-01-10 17:49:04 UTC

Confirming the update works but not necessarily as I expected.

I had been running the latest master branch and this allowed Cloudflare updates using their API Token. This version 3.9.1 of ddclient gives "ddclient 'login=' is an invalid login", i.e a blank login is not allowed, if you use an API Token as you don't specify a login with an API Token. I switched to a login and API Key and it updated correctly. Presumably the API Token mods are sometime after 3.9.1 was released. No matter apart from a few more grey hairs.

Thanks for the update.

Comment 4 Scott Talbert 2021-01-11 14:21:35 UTC

(In reply to Nick from comment #3)
> Confirming the update works but not necessarily as I expected.
> 
> I had been running the latest master branch and this allowed Cloudflare
> updates using their API Token. This version 3.9.1 of ddclient gives
> "ddclient 'login=' is an invalid login", i.e a blank login is not allowed,
> if you use an API Token as you don't specify a login with an API Token. I
> switched to a login and API Key and it updated correctly. Presumably the API
> Token mods are sometime after 3.9.1 was released. No matter apart from a few
> more grey hairs.
> 
> Thanks for the update.

Looks like there has been a fair amount of work since 3.9.1 was released.  Feel free to pester upstream for a new release and I'd be happy to pick it up.  Or if the changes you need are relatively self-contained, I could pick up a patch.

Comment 5 Nick 2021-01-11 17:32:39 UTC

I am happy with what you've done so far as I can use the Login/API Key method. I think switching to an indeterminate patch level from master could be asking for problems. I can ask upstream what they are planning, but I don't think it should hold up your release.

Comment 6 Fedora Update System 2021-01-25 01:35:44 UTC

FEDORA-EPEL-2021-44377d8bc7 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.