Bug 1914667

Summary: Lack of Fedora-specific linker flags
Product: [Fedora] Fedora Reporter: Robert Scheck <redhat-bugzilla>
Component: lua-readlineAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: lua-readline-2.9-3.fc33 lua-readline-2.9-3.fc32 lua-readline-2.9-3.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-06 01:16:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robert Scheck 2021-01-10 17:05:39 UTC
Description of problem:
As of writing, the package lacks the Fedora-specific linker flags:

> gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -llua -lm -ldl -I/usr/include/readline -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -lreadline -c C-readline.c
> gcc -shared -o C-readline.so C-readline.o

Version-Release number of selected component (if applicable):
lua-readline-2.7-1.fc34

Actual results:
Usage %{optflags}/$RPM_OPT_FLAGS only.

Expected results:
Additional usage of $RPM_LD_FLAGS during linking.

Comment 1 Robert Scheck 2021-01-10 17:11:50 UTC
Patch suggestion: https://src.fedoraproject.org/rpms/lua-readline/pull-request/3

Comment 2 Michel Lind 2021-01-27 05:10:38 UTC
Thanks! Merged

Comment 3 Fedora Update System 2021-01-27 06:45:25 UTC
FEDORA-2021-0bbaf0b045 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0bbaf0b045

Comment 4 Fedora Update System 2021-01-27 06:45:26 UTC
FEDORA-EPEL-2021-21532ad9b8 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-21532ad9b8

Comment 5 Fedora Update System 2021-01-27 06:45:27 UTC
FEDORA-2021-78c5fe6bf5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-78c5fe6bf5

Comment 6 Fedora Update System 2021-01-28 01:53:51 UTC
FEDORA-2021-78c5fe6bf5 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-78c5fe6bf5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-78c5fe6bf5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-01-28 02:01:41 UTC
FEDORA-EPEL-2021-21532ad9b8 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-21532ad9b8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-01-28 04:13:37 UTC
FEDORA-2021-0bbaf0b045 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-0bbaf0b045`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0bbaf0b045

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-01-29 02:01:32 UTC
FEDORA-2021-f353e6a60a has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-f353e6a60a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f353e6a60a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-01-29 03:08:57 UTC
FEDORA-EPEL-2021-09f86c8ee8 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-09f86c8ee8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-02-06 01:16:20 UTC
FEDORA-2021-f353e6a60a has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2021-02-06 01:30:07 UTC
FEDORA-2021-27943026aa has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2021-02-13 02:07:24 UTC
FEDORA-EPEL-2021-09f86c8ee8 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.