Bug 1914898

Summary:	check_ntp.pl plugin doesn't work with ntpsec ntpdate
Product:	[Fedora] Fedora	Reporter:	Miroslav Lichvar <mlichvar>
Component:	nagios-plugins	Assignee:	Guido Aulisi <guido.aulisi>
Status:	POST ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	42	CC:	b.heden, herrold, lemenkov, smooge, swilkerson, xavier, zbyszek
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-25 19:28:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miroslav Lichvar 2021-01-11 12:51:59 UTC

Description of problem:
In Fedora 34 ntp will probably be replaced with ntpsec:
https://fedoraproject.org/wiki/Changes/NtpReplacement

ntpsec provides a minimal ntpdate script for compatibility, but it has a different output which breaks the check_ntp.pl plugin.

A patch was submitted upstream:
https://github.com/nagios-plugins/nagios-plugins/pull/581

Please consider including it in the Fedora package.

Steps to Reproduce:
1. upgrade to ntpsec
2. run check_ntp.pl

Actual results:
Use of uninitialized value $offset in concatenation (.) or string at /usr/lib64/nagios/plugins/check_ntp.pl line 439.
NTP UNKNOWN: 2021-01-11 13:48:34.717052 (+0100) +0.000020 +/- 0.000092 127.0.0.1 s3 no-leap
Server for ntp probably down|offset=, jitter=0.0004307,peer_stratum=2

Expected results:
NTP OK: Offset +0.000020 secs, jitter 0.4307 msec, peer is stratum 2|offset=+0.000020, jitter=0.0004307,peer_stratum=2

Comment 1 Ben Cotton 2021-02-09 15:39:31 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 2 Ben Cotton 2022-02-08 21:12:25 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 3 Ben Cotton 2023-04-25 18:22:24 UTC

This message is a reminder that Fedora Linux 36 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '36'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 36 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 4 Ludek Smid 2023-05-25 19:28:31 UTC

Fedora Linux 36 entered end-of-life (EOL) status on 2023-05-16.

Fedora Linux 36 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 5 Zbigniew Jędrzejewski-Szmek 2025-02-19 15:29:36 UTC

https://github.com/nagios-plugins/nagios-plugins/pull/581

Comment 6 Aoife Moloney 2025-02-26 12:51:05 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.