Bug 1915359

Summary:	User can define the same repository ID multiple times
Product:	Red Hat Enterprise Linux 8	Reporter:	Renaud Métrich <rmetrich>
Component:	osbuild-composer	Assignee:	Brian Lane <bcl>
Status:	CLOSED ERRATA	QA Contact:	Release Test Team <release-test-team-automation>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	8.3	CC:	atodorov, bcl, obudai, tgunders
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.0
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-18 15:43:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Renaud Métrich 2021-01-12 14:06:44 UTC

Description of problem:

This is a follow-up of BZ #1915353.
When adding a repository, it's possible to use an already-defined repo ID, as shown in the example below:

baseos-pulp.txt:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
name = "baseos-pulp"
type = "yum-baseurl"
url = "http://pulp.dist.prod.ext.phx2.redhat.com/content/dist/rhel8/8/$basearch/baseos/os/"
check_gpg = false
check_ssl = false
gpgkey_urls = []
id = "baseos"
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

# composer-cli sources add baseos-pulp.txt
-> OK

This ends up having 2 "baseos" sources.

# composer-cli sources list
baseos
baseos
appstream


Addtionally, it's unclear which one takes precedence and how to show information onthe newly added one.
Finally it's not possible to delete that broken source anymore, since "baseos" is a read-only "system" source.

# composer-cli sources delete baseos
[...] baseos is a system source, it cannot be deleted.


Version-Release number of selected component (if applicable):

composer-cli-28.14.55-2.el8.x86_64


How reproducible:

ALWAYS, see above.

Comment 1 Tom Gundersen 2021-01-24 16:41:53 UTC

Thanks for the report! This seems like something we should simply refuse.

Comment 3 Brian Lane 2021-01-27 22:28:41 UTC

PR to fix the issue upstream - https://github.com/osbuild/osbuild-composer/pull/1183

Comment 6 Alexander Todorov 2021-02-12 07:36:57 UTC

[root@kvm-02-guest10 ~]# cat myrepo.toml 
name = "baseos duplicate"
id = "baseos"
type = "yum-baseurl"
url = "http://download.devel.redhat.com/rhel-8/rel-eng/RHEL-8/latest-RHEL-8/compose/BaseOS/x86_64/os"
check_gpg = false
check_ssl = true
system = true

[root@kvm-02-guest10 ~]# rpm -q composer-cli 
composer-cli-28.14.57-1.el8.x86_64

# composer-cli sources add myrepo.toml 
2021-02-12 07:36:03,577: baseos is a system source, it cannot be changed.


Moving to VERIFIED.

Comment 9 errata-xmlrpc 2021-05-18 15:43:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (osbuild bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1825