Bug 1915681

Summary: virt-install don't support vcpusched and emulatorpin
Product: Red Hat Enterprise Linux 9 Reporter: mhou <mhou>
Component: virt-managerAssignee: Jonathon Jongsma <jjongsma>
virt-manager sub component: Common QA Contact: mhou <mhou>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: medium    
Priority: unspecified CC: bhu, crobinso, hongzliu, jdenemar, jjongsma, jsuchane, junzhao, juzhou, kzhang, mhou, phrdina, tyan, tzheng, virt-maint
Version: 9.0Keywords: FutureFeature, Reopened, TestOnly, Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-manager-4.0.0-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-29 08:46:29 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2100525    
Bug Blocks:    

Description mhou 2021-01-13 08:31:26 UTC 
Description of problem:
virt-install don't support vcpusched and emulatorpin when create a new vm.

Version-Release number of selected component (if applicable):
virt-install-2.2.1-3.el8.noarch

How reproducible:
100%

Steps to Reproduce:
1.Create virtual machine support vcpusched, emulatorpin. as below:
 <cputune>
    <vcpupin vcpu='0' cpuset='16'/>
    <vcpupin vcpu='1' cpuset='18'/>
    <vcpupin vcpu='2' cpuset='1'/>
    <vcpupin vcpu='3' cpuset='3'/>
    <vcpupin vcpu='4' cpuset='5'/>
    <vcpupin vcpu='5' cpuset='7'/>
    <vcpupin vcpu='6' cpuset='9'/>
    <vcpupin vcpu='7' cpuset='11'/>
    <vcpupin vcpu='8' cpuset='13'/>
    <vcpupin vcpu='9' cpuset='15'/>
    <emulatorpin cpuset='2,4,6,8,10'/>
    <emulatorsched scheduler='fifo' priority='1'/>
    <vcpusched vcpus='0' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='1' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='2' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='3' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='4' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='5' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='6' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='7' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='8' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='9' scheduler='fifo' priority='1'/>
  </cputune>
2.use below command to create vm
virt-install \
--name houminxi \
--memory 4096 \
--memory currentMemory=4096 \
--memorybacking hugepages=yes \
--memorybacking hugepages.page.size=1 \
--memorybacking hugepages.page.unit=G \
--memorybacking locked=yes \
--arch x86_64 \
--os-type linux \
--os-variant rhel8.2 \
--cpu host-passthrough,require=tsc-deadline \
--vcpus 10 \
--cputune vcpupin0.vcpu=0,vcpupin0.cpuset=4,\
vcpupin1.vcpu=1,vcpupin1.cpuset=6,\
vcpupin2.vcpu=2,vcpupin2.cpuset=8,\
vcpupin3.vcpu=3,vcpupin3.cpuset=10,\
vcpupin4.vcpu=4,vcpupin4.cpuset=12,\
vcpupin5.vcpu=5,vcpupin5.cpuset=14,\
vcpupin6.vcpu=6,vcpupin6.cpuset=16,\
vcpupin7.vcpu=7,vcpupin7.cpuset=18,\
vcpupin8.vcpu=8,vcpupin8.cpuset=20,\
vcpupin9.vcpu=9,vcpupin9.cpuset=22 \
--disk path=/var/lib/libvirt/images/houminxi.qcow2,device=disk,bus=virtio,format=qcow2 \
--network bridge=virbr0,model=virtio,mac=00:16:3e:0e:e2:ff \
--network bridge=virbr1,model=virtio,mac=00:16:3e:68:84:64 \
--boot hd \
--accelerate \
--graphics none \
--force \
--os-type=linux \
--noautoconsol

Actual results:
virt-install command can't support defining emulatorsched and vcpusched

Expected results:
virt-install can support domain xml element such as emulatorsched and vcpusched.

Additional info:
Comment 2 RHEL Program Management 2022-07-13 07:28:26 UTC 
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.
Comment 3 mhou 2022-08-08 12:36:08 UTC 
+ Beth Uptagrafft for visibility 

Hello folks

If virt-install does not support vcpupin and emulatorpin, it can only be installed by virsh define ${guest}.xml. Please confirm that we are not considering support for this feature on virt-install.

Thanks
Comment 5 Cole Robinson 2022-08-21 20:06:24 UTC 
I believe virt-manager 4.0.0 supports all emulator[sched|pin] and vcpu[sched|pin] config
Comment 6 mhou 2022-08-22 02:27:27 UTC 
Hello Cole 

In which RHEL distro will Virtual Manager 4.0.0 be included by default?
Comment 7 tingting zheng 2022-08-22 03:07:55 UTC 
(In reply to mhou from comment #6)
> Hello Cole 
> 
> In which RHEL distro will Virtual Manager 4.0.0 be included by default?

The latest RHEL9.1 compose should include virt-manager 4.0, pls check:http://download.eng.pek2.redhat.com//rhel-9/nightly/RHEL-9/RHEL-9.1.0-20220819.0/compose/AppStream/x86_64/os/Packages/
Comment 8 John Ferlan 2022-08-22 10:53:45 UTC 
Changing to ON_QA and adding TestOnly keyword - sorry this has been discovered late. I know this avoids the errata process for the bug, but can we just validate this please?
Comment 9 mhou 2022-08-22 13:20:45 UTC 
Hello John

I can't found emulator[sched|pin] or vcpu[sched|pin] configuration on virt-manager. The host success installs virt-manager-4.0.0-1 on my test bed. But when I use virt-manager to start a guest, I can't find any emulator[sched|pin] or vcpu[sched|pin] configuration on cpu item. Please check the screenshot on attachment. 

# rpm -qa | grep virt-manager
virt-manager-common-4.0.0-1.el9.noarch
virt-manager-4.0.0-1.el9.noarch

If needed, I will provide my test bed.
Comment 12 Cole Robinson 2022-08-22 14:12:57 UTC 
Sorry, my comment was ambiguous. virt-manager-4.0.0 the upstream release has these bits, but in virt-install and virt-xml only, which is what this bug was covering. There are no plans to expose this in virt-manager UI.
Comment 13 mhou 2022-08-23 03:17:00 UTC 
Hello Cole

I follow "man virt-install" to install guest that contain hugepage memory and cputune but failed. Could you please kindly help me a look this issue?

virt-install \
        --name g1 \
        --memory memory=8192,currentMemory=8192 \
        --memorybacking access.mode=shared,hugepages.page0.size=1048576,hugepages.page0.unit=KiB \
        --arch x86_64 \
        --machine q35 \
        --vcpus 10,vcpu.placement=static\
        --numatune memory.mode=strict,memory.nodeset=0,memnode0.nodeset=0,memnode0.cellid=0,memnode0.mode=strict \
        --cpu force=require,+tsc-deadline,mode=host-passthrough,check=none,migratable=on,numa.cell0.id=0,numa.cell0.memory=8,numa.cell0.unit=G,numa.cell1.cpus=0-9 \
       --cputune=vcpupin0.vcpu=0,vcpupin0.cpuset=2,vcpupin1.vcpu=1,vcpupin1.cpuset=4,vcpupin2.vcpu=2,vcpupin2.cpuset=6,vcpupin3.vcpu=3,vcpupin3.cpuset=8,vcpupin4.vcpu=4,vcpupin4.cpuset=10,vcpupin5.vcpu=5,vcpupin5.cpuset=12,vcpupin6.vcpu=6,vcpupin6.cpuset=14,vcpupin7.vcpu=7,vcpupin7.cpuset=16,vcpupin8.vcpu=8,vcpupin8.cpuset=18,vcpupin9.vcpu=9,vcpupin9.cpuset=20,vcpusched0.vcpus=0,vcpusched1.vcpus=1,vcpusched2.vcpus=2,vcpusched3.vcpus=3,vcpusched4.vcpus=4,vcpusched5.vcpus=5,vcpusched6.vcpus=6,vcpusched7.vcpus=7,vcpusched8.vcpus=8,vcpusched9.vcpus=9,vcpusched0.priority=1,vcpusched1.priority=1,vcpusched2.priority=1,vcpusched3.priority=1,vcpusched4.priority=1,vcpusched5.priority=1,vcpusched6.priority=1,vcpusched7.priority=1,vcpusched8.priority=1,vcpusched9.priority=1,vcpusched0.scheduler=fifo,vcpusched1.scheduler=fifo,vcpusched2.scheduler=fifo,vcpusched3.scheduler=fifo,vcpusched4.scheduler=fifo,vcpusched5.scheduler=fifo,vcpusched6.scheduler=fifo,vcpusched7.scheduler=fifo,vcpusched8.scheduler=fifo,vcpusched9.scheduler=fifo  \
        --feature acpi=on,pmu.state=off,vmport.state=off,ioapic.driver=qemu \
        --osinfo detect=on,require=off \
        --disk path=/var/lib/libvirt/images/RHEL-9.0-5.14.0-70.13.1.rt21.83.el9_0.qcow2,device=disk,bus=virtio,format=qcow2 \
        --network bridge=virbr0,model=virtio \
        --boot hd \
        --accelerate \
        --force \
        --graphics vnc,listen=0.0.0.0 \
        --noautoconsole --debug
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (virtinstall:212) Distilled --network options: ['bridge=virbr0,model=virtio']
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (virtinstall:142) Distilled --disk options: ['path=/var/lib/libvirt/images/RHEL-9.0-5.14.0-70.13.1.rt21.83.el9_0.qcow2,device=disk,bus=virtio,format=qcow2']
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (cli:216) Requesting libvirt URI default
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (cli:219) Received libvirt URI qemu:///system
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (guest:330) Setting Guest osinfo name <_OsVariant name=generic>
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (installer:542) No media for distro detection.
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (installer:544) installer.detect_distro returned=None
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (guest:535) Prefer EFI => False
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (guest:1094) Using num_pcie_root_ports=14
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (disk:236) DeviceDisk.check_path_search path=/var/lib/libvirt/images/RHEL-9.0-5.14.0-70.13.1.rt21.83.el9_0.qcow2
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] WARNING (virtinstall:373) Using --osinfo generic, VM performance may suffer. Specify an accurate OS for optimal results.
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (cli:265) 
Starting install...

Starting install...
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (installer:587) Generated initial_xml: None required
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (installer:589) Generated final_xml: 
<domain type="kvm">
  <name>g1</name>
  <uuid>63586089-634a-4c14-b063-35f39849ff81</uuid>
  <memory>8388608</memory>
  <currentMemory>8388608</currentMemory>
  <memoryBacking>
    <hugepages>
      <page size="1048576" unit="KiB"/>
    </hugepages>
    <access mode="shared"/>
  </memoryBacking>
  <vcpu placement="static">10</vcpu>
  <numatune>
    <memory mode="strict" nodeset="0"/>
    <memnode cellid="0" mode="strict" nodeset="0"/>
  </numatune>
  <os>
    <type arch="x86_64" machine="q35">hvm</type>
    <boot dev="hd"/>
  </os>
  <features>
    <acpi/>
    <apic/>
    <pmu state="off"/>
    <vmport state="off"/>
    <ioapic driver="qemu"/>
  </features>
  <cpu mode="host-passthrough" check="none" migratable="on">
    <feature policy="force" name="require"/>
    <feature policy="force" name="tsc-deadline"/>
    <numa>
      <cell id="0" memory="8" unit="G"/>
      <cell cpus="0-9"/>
    </numa>
  </cpu>
  <clock offset="utc">
    <timer name="rtc" tickpolicy="catchup"/>
    <timer name="pit" tickpolicy="delay"/>
    <timer name="hpet" present="no"/>
  </clock>
  <pm>
    <suspend-to-mem enabled="no"/>
    <suspend-to-disk enabled="no"/>
  </pm>
  <devices>
    <emulator>/usr/libexec/qemu-kvm</emulator>
    <disk type="file" device="disk">
      <driver name="qemu" type="qcow2"/>
      <source file="/var/lib/libvirt/images/RHEL-9.0-5.14.0-70.13.1.rt21.83.el9_0.qcow2"/>
      <target dev="vda" bus="virtio"/>
    </disk>
    <controller type="usb" model="ich9-ehci1"/>
    <controller type="usb" model="ich9-uhci1">
      <master startport="0"/>
    </controller>
    <controller type="usb" model="ich9-uhci2">
      <master startport="2"/>
    </controller>
    <controller type="usb" model="ich9-uhci3">
      <master startport="4"/>
    </controller>
    <controller type="pci" model="pcie-root"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <controller type="pci" model="pcie-root-port"/>
    <interface type="bridge">
      <source bridge="virbr0"/>
      <mac address="52:54:00:78:a7:c4"/>
      <model type="virtio"/>
    </interface>
    <console type="pty"/>
    <input type="tablet" bus="usb"/>
    <graphics type="vnc" port="-1" listen="0.0.0.0"/>
    <video>
      <model type="vga"/>
    </video>
  </devices>
  <cputune>
    <vcpupin vcpu="0" cpuset="2"/>
    <vcpupin vcpu="1" cpuset="4"/>
    <vcpupin vcpu="2" cpuset="6"/>
    <vcpupin vcpu="3" cpuset="8"/>
    <vcpupin vcpu="4" cpuset="10"/>
    <vcpupin vcpu="5" cpuset="12"/>
    <vcpupin vcpu="6" cpuset="14"/>
    <vcpupin vcpu="7" cpuset="16"/>
    <vcpupin vcpu="8" cpuset="18"/>
    <vcpupin vcpu="9" cpuset="20"/>
    <vcpusched vcpus="0" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="1" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="2" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="3" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="4" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="5" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="6" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="7" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="8" scheduler="fifo" priority="1"/>
    <vcpusched vcpus="9" scheduler="fifo" priority="1"/>
  </cputune>
</domain>

[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (cli:255)   File "/usr/bin/virt-install", line 8, in <module>
    virtinstall.runcli()
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1220, in runcli
    sys.exit(main())
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1213, in main
    start_install(guest, installer, options)
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 961, in start_install
    fail(e, do_exit=False)
  File "/usr/share/virt-manager/virtinst/cli.py", line 255, in fail
    log.debug("".join(traceback.format_stack()))

[Mon, 22 Aug 2022 23:16:21 virt-install 31503] ERROR (cli:256) XML error: missing element or attribute './@memory'
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (cli:258) 
Traceback (most recent call last):
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 941, in start_install
    domain = installer.start_install(
  File "/usr/share/virt-manager/virtinst/install/installer.py", line 695, in start_install
    domain = self._create_guest(
  File "/usr/share/virt-manager/virtinst/install/installer.py", line 637, in _create_guest
    domain = self.conn.createXML(initial_xml or final_xml, 0)
  File "/usr/lib64/python3.9/site-packages/libvirt.py", line 4442, in createXML
    raise libvirtError('virDomainCreateXML() failed')
libvirt.libvirtError: XML error: missing element or attribute './@memory'
[Mon, 22 Aug 2022 23:16:21 virt-install 31503] DEBUG (cli:271) Domain installation does not appear to have been successful.
If it was, you can restart your domain by running:
  virsh --connect qemu:///system start g1
otherwise, please restart your installation.
Domain installation does not appear to have been successful.
If it was, you can restart your domain by running:
  virsh --connect qemu:///system start g1
otherwise, please restart your installation.
Comment 14 tingting zheng 2022-08-23 07:26:33 UTC 
Hi, Hongzhou

Would you pls also help to test the bug from virt-install and check whether we need to update virt-install test plan, thanks.
Comment 15 mhou 2022-08-23 07:27:47 UTC 
Please ignore comment13. I fix this issue by myself. Here is the correct command:
virt-install \
        --name g1 \
        --memory memory=8192,currentMemory=8192 \
        --memorybacking access.mode=shared,hugepages.page0.size=1048576,hugepages.page0.unit=KiB \
        --arch x86_64 \
        --machine q35 \
        --vcpus 10,vcpu.placement=static\
        --numatune memory.mode=strict,memory.nodeset=0,memnode0.nodeset=0,memnode0.cellid=0,memnode0.mode=strict \
        --cpu mode=host-passthrough,require=tsc-deadline,check=none,migratable=on,numa.cell0.id=0,numa.cell0.memory=1,numa.cell0.unit=G,numa.cell0.cpus=0-9,numa.cell0.memAccess=shared \
       --cputune=vcpupin0.vcpu=0,vcpupin0.cpuset=2,vcpupin1.vcpu=1,vcpupin1.cpuset=4,vcpupin2.vcpu=2,vcpupin2.cpuset=6,vcpupin3.vcpu=3,vcpupin3.cpuset=8,vcpupin4.vcpu=4,vcpupin4.cpuset=10,vcpupin5.vcpu=5,vcpupin5.cpuset=12,vcpupin6.vcpu=6,vcpupin6.cpuset=14,vcpupin7.vcpu=7,vcpupin7.cpuset=16,vcpupin8.vcpu=8,vcpupin8.cpuset=18,vcpupin9.vcpu=9,vcpupin9.cpuset=20,vcpusched0.vcpus=0,vcpusched1.vcpus=1,vcpusched2.vcpus=2,vcpusched3.vcpus=3,vcpusched4.vcpus=4,vcpusched5.vcpus=5,vcpusched6.vcpus=6,vcpusched7.vcpus=7,vcpusched8.vcpus=8,vcpusched9.vcpus=9,vcpusched0.priority=1,vcpusched1.priority=1,vcpusched2.priority=1,vcpusched3.priority=1,vcpusched4.priority=1,vcpusched5.priority=1,vcpusched6.priority=1,vcpusched7.priority=1,vcpusched8.priority=1,vcpusched9.priority=1,vcpusched0.scheduler=fifo,vcpusched1.scheduler=fifo,vcpusched2.scheduler=fifo,vcpusched3.scheduler=fifo,vcpusched4.scheduler=fifo,vcpusched5.scheduler=fifo,vcpusched6.scheduler=fifo,vcpusched7.scheduler=fifo,vcpusched8.scheduler=fifo,vcpusched9.scheduler=fifo,emulatorpin.cpuset=0,emulatorsched.priority=1,emulatorsched.scheduler=fifo  \
        --feature acpi=on,pmu.state=off,vmport.state=off,ioapic.driver=qemu \
        --osinfo detect=on,require=off \
        --disk path=/var/lib/libvirt/images/RHEL-9.0-5.14.0-70.13.1.rt21.83.el9_0.qcow2,device=disk,bus=virtio,format=qcow2 \
        --network bridge=virbr0,model=virtio \
        --boot hd \
        --accelerate \
        --force \
        --graphics vnc,listen=0.0.0.0 \
        --noautoconsole

# virsh dumpxml g1
<domain type='kvm' id='1'>
  <name>g1</name>
  <uuid>e504e4fe-dd2b-4fce-ab3d-ddf706d3e292</uuid>
  <memory unit='KiB'>1048576</memory>
  <currentMemory unit='KiB'>1048576</currentMemory>
  <memoryBacking>
    <hugepages>
      <page size='1048576' unit='KiB'/>
    </hugepages>
    <access mode='shared'/>
  </memoryBacking>
  <vcpu placement='static'>10</vcpu>
  <cputune>
    <vcpupin vcpu='0' cpuset='2'/>
    <vcpupin vcpu='1' cpuset='4'/>
    <vcpupin vcpu='2' cpuset='6'/>
    <vcpupin vcpu='3' cpuset='8'/>
    <vcpupin vcpu='4' cpuset='10'/>
    <vcpupin vcpu='5' cpuset='12'/>
    <vcpupin vcpu='6' cpuset='14'/>
    <vcpupin vcpu='7' cpuset='16'/>
    <vcpupin vcpu='8' cpuset='18'/>
    <vcpupin vcpu='9' cpuset='20'/>
    <emulatorpin cpuset='0'/>
    <emulatorsched scheduler='fifo' priority='1'/>
    <vcpusched vcpus='0' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='1' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='2' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='3' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='4' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='5' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='6' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='7' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='8' scheduler='fifo' priority='1'/>
    <vcpusched vcpus='9' scheduler='fifo' priority='1'/>
  </cputune>
  <numatune>
    <memory mode='strict' nodeset='0'/>
    <memnode cellid='0' mode='strict' nodeset='0'/>
  </numatune>
  <resource>
    <partition>/machine</partition>
  </resource>
  <os>
    <type arch='x86_64' machine='pc-q35-rhel9.0.0'>hvm</type>
    <boot dev='hd'/>
  </os>
  <features>
    <acpi/>
    <apic/>
    <pmu state='off'/>
    <vmport state='off'/>
    <ioapic driver='qemu'/>
  </features>
  <cpu mode='host-passthrough' check='none' migratable='on'>
    <feature policy='require' name='tsc-deadline'/>
    <numa>
      <cell id='0' cpus='0-9' memory='1048576' unit='KiB' memAccess='shared'/>
    </numa>
  </cpu>
  <clock offset='utc'>
    <timer name='rtc' tickpolicy='catchup'/>
    <timer name='pit' tickpolicy='delay'/>
    <timer name='hpet' present='no'/>
  </clock>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>destroy</on_crash>
  <pm>
    <suspend-to-mem enabled='no'/>
    <suspend-to-disk enabled='no'/>
  </pm>
  <devices>
    <emulator>/usr/libexec/qemu-kvm</emulator>
    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/var/lib/libvirt/images/RHEL-9.0-5.14.0-70.13.1.rt21.83.el9_0.qcow2' index='1'/>
      <backingStore/>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x02' slot='0x00' function='0x0'/>
    </disk>
    <controller type='usb' index='0' model='ich9-ehci1'>
      <alias name='usb'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x7'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci1'>
      <alias name='usb'/>
      <master startport='0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x0' multifunction='on'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci2'>
      <alias name='usb'/>
      <master startport='2'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x1'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci3'>
      <alias name='usb'/>
      <master startport='4'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x2'/>
    </controller>
    <controller type='pci' index='0' model='pcie-root'>
      <alias name='pcie.0'/>
    </controller>
    <controller type='pci' index='1' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='1' port='0x10'/>
      <alias name='pci.1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0' multifunction='on'/>
    </controller>
    <controller type='pci' index='2' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='2' port='0x11'/>
      <alias name='pci.2'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x1'/>
    </controller>
    <controller type='pci' index='3' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='3' port='0x12'/>
      <alias name='pci.3'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x2'/>
    </controller>
    <controller type='pci' index='4' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='4' port='0x13'/>
      <alias name='pci.4'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x3'/>
    </controller>
    <controller type='pci' index='5' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='5' port='0x14'/>
      <alias name='pci.5'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x4'/>
    </controller>
    <controller type='pci' index='6' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='6' port='0x15'/>
      <alias name='pci.6'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x5'/>
    </controller>
    <controller type='pci' index='7' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='7' port='0x16'/>
      <alias name='pci.7'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x6'/>
    </controller>
    <controller type='pci' index='8' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='8' port='0x17'/>
      <alias name='pci.8'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x7'/>
    </controller>
    <controller type='pci' index='9' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='9' port='0x18'/>
      <alias name='pci.9'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0' multifunction='on'/>
    </controller>
    <controller type='pci' index='10' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='10' port='0x19'/>
      <alias name='pci.10'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x1'/>
    </controller>
    <controller type='pci' index='11' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='11' port='0x1a'/>
      <alias name='pci.11'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x2'/>
    </controller>
    <controller type='pci' index='12' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='12' port='0x1b'/>
      <alias name='pci.12'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x3'/>
    </controller>
    <controller type='pci' index='13' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='13' port='0x1c'/>
      <alias name='pci.13'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x4'/>
    </controller>
    <controller type='pci' index='14' model='pcie-root-port'>
      <model name='pcie-root-port'/>
      <target chassis='14' port='0x1d'/>
      <alias name='pci.14'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x5'/>
    </controller>
    <controller type='sata' index='0'>
      <alias name='ide'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x1f' function='0x2'/>
    </controller>
    <interface type='bridge'>
      <mac address='52:54:00:ea:e2:88'/>
      <source bridge='virbr0'/>
      <target dev='vnet0'/>
      <model type='virtio'/>
      <alias name='net0'/>
      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
    </interface>
    <serial type='pty'>
      <source path='/dev/pts/3'/>
      <target type='isa-serial' port='0'>
        <model name='isa-serial'/>
      </target>
      <alias name='serial0'/>
    </serial>
    <console type='pty' tty='/dev/pts/3'>
      <source path='/dev/pts/3'/>
      <target type='serial' port='0'/>
      <alias name='serial0'/>
    </console>
    <input type='tablet' bus='usb'>
      <alias name='input0'/>
      <address type='usb' bus='0' port='1'/>
    </input>
    <input type='mouse' bus='ps2'>
      <alias name='input1'/>
    </input>
    <input type='keyboard' bus='ps2'>
      <alias name='input2'/>
    </input>
    <graphics type='vnc' port='5900' autoport='yes' listen='0.0.0.0'>
      <listen type='address' address='0.0.0.0'/>
    </graphics>
    <audio id='1' type='none'/>
    <video>
      <model type='vga' vram='16384' heads='1' primary='yes'/>
      <alias name='video0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/>
    </video>
    <memballoon model='virtio'>
      <alias name='balloon0'/>
      <address type='pci' domain='0x0000' bus='0x03' slot='0x00' function='0x0'/>
    </memballoon>
  </devices>
  <seclabel type='dynamic' model='selinux' relabel='yes'>
    <label>system_u:system_r:svirt_t:s0:c272,c421</label>
    <imagelabel>system_u:object_r:svirt_image_t:s0:c272,c421</imagelabel>
  </seclabel>
  <seclabel type='dynamic' model='dac' relabel='yes'>
    <label>+107:+107</label>
    <imagelabel>+107:+107</imagelabel>
  </seclabel>
</domain>
Comment 16 mhou 2022-08-23 07:38:50 UTC 
Hello Cole

One more things need to check with you. Will the virt-manager-4.0.0-1 version be backported to rhel8?
Comment 17 Hongzhou Liu 2022-08-23 10:45:10 UTC 
(In reply to mhou from comment #16)
> Hello Cole
> 
> One more things need to check with you. Will the virt-manager-4.0.0-1
> version be backported to rhel8?

Hello mhou, The answer is negative, On RHEL8, we still using virt-manager-3.2.0
Comment 18 John Ferlan 2022-08-23 11:37:24 UTC 
Jonathon - since you're the downstream maintainer... 

Do you plan to rebase virt-manager for say 8.8.0 (I know it's too late for 8.7.0)?  Similar to bug 2009080 which updated and kept RHEL 8.6/9.0 in sync...

I have to imagine questions like this will come up a bit more frequently seeing as there's still quite a few RHEL8 consumers.
Comment 19 mhou 2022-08-23 11:38:01 UTC 
Hello Hongzhou

Many thanks for your information. It's very clear for me.

From my side, I verify this feature work as well. More detail info, please check comment15. 

Let me know should I verify this bug, or you need more investigation.
Comment 20 Hongzhou Liu 2022-08-24 03:35:23 UTC 
(In reply to mhou from comment #19)
> Hello Hongzhou
> 
> Many thanks for your information. It's very clear for me.
> 
> From my side, I verify this feature work as well. More detail info, please
> check comment15. 
> 
> Let me know should I verify this bug, or you need more investigation.

Hello mhou, can you provide the versions for virt-manager virt-install and libvirt in comment 15, and did you run this command on RHEL9.1 or RHEL9.0?
if you use the latest packages and RHEL9.1 then I think you can verify this bug now.

Thanks
Comment 21 mhou 2022-08-24 06:36:13 UTC 
Hello Hongzhou

Test distro is: http://download.eng.pek2.redhat.com//rhel-9/nightly/RHEL-9/RHEL-9.1.0-20220819.0/compose/AppStream/x86_64/os/Packages/
virt-manager: virt-manager-4.0.0-1.el9.x86_64
virt-install: virt-install-4.0.0-1.el9.noarch
Comment 22 mhou 2022-08-24 06:39:43 UTC 
Hello Jonathon

Same question with John. Do you have any plan to rebase virt-manager for rhel 8.8.0?
Comment 23 Hongzhou Liu 2022-08-24 07:52:10 UTC 
(In reply to mhou from comment #22)
> Hello Jonathon
> 
> Same question with John. Do you have any plan to rebase virt-manager for
> rhel 8.8.0?

Hello Minxi, There is a rebase plan for RHEL8.8 Bug 2120844
Comment 24 John Ferlan 2022-08-24 10:46:17 UTC 
clearing needinfo as it's resolved with the noted bug.