Bug 1915850

Summary: Rollback not working with a linux-bridge on default bridge at OCP with OVN Kubernetes
Product: Red Hat Enterprise Linux 8 Reporter: Quique Llorente <ellorent>
Component: nmstateAssignee: Gris Ge <fge>
Status: CLOSED ERRATA QA Contact: Mingyu Shi <mshi>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.3CC: ferferna, fge, jiji, jishi, network-qe, phoracek, till
Target Milestone: rcKeywords: NeedsTestCase, Triaged
Target Release: 8.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: nmstate-1.1.0-0.1.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 17:42:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1896469    
Attachments:
Description Flags
State to set
none
NetworkManager debug logs
none
show state before set
none
show state after set
none
show state after rollback none

Description Quique Llorente 2021-01-13 14:36:10 UTC
Created attachment 1747088 [details]
State to set

Description of problem:

At a OCP 4.7 cluster using nmstate 0.3.4 to create a linux-bridge in top of primary nic "ens3" and rolling it back fails at rolling it back and make the node connectivity being lost.

The OCP cluster is using OVN Kubernetes and the ens3 is already a slave under a ovs bridge "br-ext", issue is that rollback is not able to recover from the issue.


Version-Release number of selected component (if applicable):
nmstate 0.3.4-17


How reproducible:


ssh into a OCP 4.7 worker and set a password for root since we need to access to it using libvirt console or openstack console.

Then access to the worker using libvirt/openstack commands since connectivity is going to be lost ssh connection is broken.

Steps to Reproduce:
1. ping www.redhat.com
2. ./nmstatectl.sh set --no-commit --timeout 120 /quique/state.yaml
3. ping www.redhat.com (Connectivity is lost)
4. ./nmstatectl.sh rollback
5. ping www.redhat.com (Connectivity still lost)

Actual results:
nmstate is not able to rollback this configuration


Expected results:
nmstate restoring network configuration so we don't lose connectivity.


Additional info:

Comment 1 Quique Llorente 2021-01-13 14:41:31 UTC
Created attachment 1747089 [details]
NetworkManager debug logs

Comment 2 Quique Llorente 2021-01-13 14:41:58 UTC
Created attachment 1747090 [details]
show state before set

Comment 3 Quique Llorente 2021-01-13 14:42:22 UTC
Created attachment 1747091 [details]
show state after set

Comment 4 Quique Llorente 2021-01-13 14:42:44 UTC
Created attachment 1747092 [details]
show state after rollback

Comment 5 Petr Horáček 2021-02-01 13:49:47 UTC
Gris, would you please prioritize it? Would it make it to 1.0?

Comment 6 Gris Ge 2021-02-02 10:37:20 UTC
Hi Quique,

If we are expecting fix in nmstate 1.0, could you try it on nmstate-1.0(RHEL 8.4)?

In my VM, it seems works well.

Comment 7 Fernando F. Mancera 2021-05-06 13:24:01 UTC
(In reply to Gris Ge from comment #6)
> Hi Quique,
> 
> If we are expecting fix in nmstate 1.0, could you try it on nmstate-1.0(RHEL
> 8.4)?
> 
> In my VM, it seems works well.

Please, let us know if this works on nmstate 1.0 or greater. It works well for me. Thanks!

Comment 8 Quique Llorente 2021-05-06 13:33:29 UTC
@ferferna now it's easier with the nmstate/automation we have for k8s I will give it a try.

Comment 9 Quique Llorente 2021-06-02 05:47:58 UTC
I have test it with CNV 4.8 and at a OVNKubernetes openshift cluster and now the rollback works fine creating a linux bridge with one of the ports matcing the br-ex primary nic port.

root@zeus12 quique]# oc exec  -n openshift-cnv nmstate-handler-jrpdd -- rpm -qa |grep nmstate
nmstate-1.0.2-5.el8.noarch
python3-libnmstate-1.0.2-5.el8.noarch

Comment 10 Till Maas 2021-06-02 07:34:36 UTC
(In reply to Quique Llorente from comment #9)
> I have test it with CNV 4.8 and at a OVNKubernetes openshift cluster and now
> the rollback works fine creating a linux bridge with one of the ports
> matcing the br-ex primary nic port.
> 
> root@zeus12 quique]# oc exec  -n openshift-cnv nmstate-handler-jrpdd -- rpm
> -qa |grep nmstate
> nmstate-1.0.2-5.el8.noarch
> python3-libnmstate-1.0.2-5.el8.noarch

If it works, what are your expectations to happen here?

Comment 11 Gris Ge 2021-06-02 08:27:14 UTC
Reporter(Quique Llorente) agree on bug closure.

But let's keep this bug for QE or devel effort to create auto test case for this.

Comment 15 Mingyu Shi 2021-06-20 05:49:23 UTC
As it works on nmstate-1.0 and above, mark as verified

Comment 17 errata-xmlrpc 2021-11-09 17:42:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4157