Bug 191592
Summary: | Review Request: vorbisgain - Adds tags to Ogg Vorbis files to adjust the volume | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Noa Resare <noa> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.34-2.fc5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-28 13:15:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Noa Resare
2006-05-13 15:48:47 UTC
MD5Sums: ee62352b74c610bb3eeddda038819fc8 vorbisgain-0.34.zip Good: * Source URL is canonical * Upstream source tarball verified * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * rpmlint produces no errors * Package installs and uninstalls cleanly on FC5 * Software runs fine Minor: * License is LGPL, not GPL. * Inconsistant use of '$RPM_BUILD_ROOT' & '%buildroot'. Use only one or the other. These two items can be corrected after you import them into FE CVS +1 APPROVE I'll also be your sponser. If you haven't created an account yet, you will need to do so. http://fedoraproject.org/wiki/Extras/Contributors#head-a89c07b5b8abe7748b6b39f0f89768d595234907 Thanks! My account name is 'noa' I've gone ahead and approved you. Once this goes thru the system, you should be able to go to the next step. http://fedoraproject.org/wiki/Extras/Contributors#head-0956b12959af46cfe0aa12d09ed15e573bfd9ef4 Has this been build for FC5 & devel yet? If so, this can be closed. Yup. And it seems to work also :) This package still needs to be built for the devel branch. Refer to https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200268 and http://fedoraproject.org/wiki/Extras/PackageStatus#head-e3ffc07096e28c4a16bc8a8a0c088d4916fe0d21. I'm just back from a few weeks of vacation, and I'm sorry about my slow response to this issue. I'm a bit uncertain if the tag generated by 'make tag' is correct (vorbisgain-0_34-1_fc6). However the package is built by the plague build system (as job id 13875) and is in status needsign at the moment. |