Bug 1917019

Summary: Review request: vdr-mcli - DVB multicast stream client for the NetCeiver hardware for VDR
Product: [Fedora] Fedora Reporter: Peter Bieringer <pb>
Component: Package ReviewAssignee: MartinKG <mgansser>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: mgansser, package-review
Target Milestone: ---Flags: mgansser: fedora-review?
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-08 08:12:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Peter Bieringer 2021-01-16 16:15:37 UTC 
Full URLs to the spec file and source rpm of the package:
ftp://ftp.bieringer.de/pub/tmp/vdr-mcli.spec
ftp://ftp.bieringer.de/pub/tmp/vdr-mcli-0.9.4-2.fc33.src.rpm


A short description for the package:
Multicast client plugin to access DVB-streams produced by the
NetCeiver hardware for VDR


Why this package is not eligible to be included in Fedora

Potential user community of this RPM is too small to be included in Fedora, similar to other VDR plugins which are also available on rpmfusion and not in Fedora.


The output rpmlint gives on both the source and binary packages:

rpmlint /home/vdrdev/rpmbuild/RPMS/x86_64/vdr-mcli-0.9.4-2.fc33.x86_64.rpm
vdr-mcli.x86_64: W: spelling-error Summary(en_US) multicast -> simulcast
vdr-mcli.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast
vdr-mcli.x86_64: W: spelling-error %description -l en_US pbiering -> piercing
vdr-mcli.x86_64: W: no-manual-page-for-binary netcvdiag
vdr-mcli.x86_64: W: no-manual-page-for-binary netcvlogview
vdr-mcli.x86_64: W: no-manual-page-for-binary netcvupdate
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

- spelling warnings: spell checker too strict, no proper sugestions
- missing manual pages: not provided by upstream


rpmlint /home/vdrdev/rpmbuild/SRPMS/vdr-mcli-0.9.4-2.fc33.src.rpm
vdr-mcli.src: W: spelling-error Summary(en_US) multicast -> simulcast
vdr-mcli.src: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast
vdr-mcli.src: W: spelling-error %description -l en_US pbiering -> piercing
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-> see above


Fedora Account System Username: pbiering
Comment 1 MartinKG 2021-01-16 16:42:25 UTC 
will take for review.
Comment 2 MartinKG 2021-01-16 17:06:02 UTC 
Please make sure that the package can also be created on the Koji Build Server with:
$ koji build --scratch rawhide ../SRPMS/vdr-mcli-0.9.4-2.fc33.src.rpm

...
../common/defs.h:183:10: fatal error: zlib.h: No such file or directory
  183 | #include <zlib.h>
      |          ^~~~~~~~
compilation terminated.

...
../common/defs.h:232:10: fatal error: libxml/encoding.h: No such file or directory
  232 | #include <libxml/encoding.h>
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.

please fix this by adding the necessary BR to your spec file.

BuildRequires:  zlib-devel
BuildRequires:  libxml2-devel
Comment 3 Peter Bieringer 2021-01-16 17:17:34 UTC 
sorry, had forgotten to create koji build in advance, now it's working: https://koji.fedoraproject.org/koji/taskinfo?taskID=59851402
Comment 4 MartinKG 2021-01-16 18:17:04 UTC 


rpmlint Checking: vdr-mcli-0.9.4-2.fc34.x86_64.rpm
          vdr-mcli-devel-0.9.4-2.fc34.x86_64.rpm
          vdr-mcli-debuginfo-0.9.4-2.fc34.x86_64.rpm
          vdr-mcli-debugsource-0.9.4-2.fc34.x86_64.rpm
          vdr-mcli-0.9.4-2.fc34.src.rpm
vdr-mcli.x86_64: W: spelling-error Summary(en_US) multicast -> simulcast
vdr-mcli.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast
vdr-mcli.x86_64: W: spelling-error %description -l en_US pbiering -> piercing
vdr-mcli.x86_64: W: no-manual-page-for-binary netcvdiag
vdr-mcli.x86_64: W: no-manual-page-for-binary netcvlogview
vdr-mcli.x86_64: W: no-manual-page-for-binary netcvupdate
vdr-mcli-devel.x86_64: W: spelling-error Summary(en_US) multicast -> simulcast
vdr-mcli-devel.x86_64: E: summary-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR
vdr-mcli-devel.x86_64: W: spelling-error %description -l en_US multicast -> simulcast
vdr-mcli-devel.x86_64: W: spelling-error %description -l en_US pbiering -> piercing
vdr-mcli-devel.x86_64: E: description-line-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR
vdr-mcli-devel.x86_64: W: no-documentation
vdr-mcli.src: W: spelling-error Summary(en_US) multicast -> simulcast
vdr-mcli.src: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast
vdr-mcli.src: W: spelling-error %description -l en_US pbiering -> piercing
5 packages and 0 specfiles checked; 2 errors, 13 warnings.

Suggested fixes:

vdr-mcli-devel.x86_64: E: summary-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR
vdr-mcli-devel.x86_64: E: description-line-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR

see fedora package guideline:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-long
Comment 5 Peter Bieringer 2021-01-16 20:17:48 UTC 
vdr-mcli-devel fixed now, overseen, sorry.
Comment 6 MartinKG 2021-01-17 10:57:45 UTC 
think, that license field must include LGPLv2+ also

see HISTORY:
2010-06-23:
- Moved the mcli-library to LGPL-2.1-license.


fix it to:
License:        GPLv2+ and LGPLv2+
Comment 7 MartinKG 2021-01-17 11:15:13 UTC 
a nother issue:

the devel package includes only the following header file mcliheaders.h

$ rpm -ql vdr-mcli-devel
/usr/include/vdr/mcliheaders.h

in this header file are following headers files included, but where are this header file in the rpm package ?

#include <mcast/common/defs.h>
#include <mcast/common/version.h>
#include <mcast/common/list.h>
#include <mcast/common/satlists.h>
#include <mcast/common/mcast.h>
#include <mcast/common/recv_ccpp.h>
#include <mcast/client/recv_tv.h>
#include <mcast/client/mld_reporter.h>
#include <mcast/client/tca_handler.h>
#include <mcast/client/tra_handler.h>
#include <mcast/common/tools.h>
#include <mcast/client/api_server.h>
#include <mcast/client/mmi_handler.h>
Comment 8 Peter Bieringer 2021-01-17 12:10:28 UTC 
License statement fixed in latest spec in ftp-server

regarding the vdr-mcli-devel, the only "external" used header file so found far is "mcliheaders.h" by the "vdr-netcv" plugin, other header files are only used inside the package to my knowledge.