Bug 1917117

Summary: Common templates - disks screen: invalid disk name
Product: OpenShift Container Platform Reporter: Ruth Netser <rnetser>
Component: Console Kubevirt PluginAssignee: Yaacov Zamir <yzamir>
Status: CLOSED ERRATA QA Contact: Guohua Ouyang <gouyang>
Severity: high Docs Contact:
Priority: high    
Version: 4.7CC: aos-bugs, gouyang, yzamir
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-24 15:53:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot
none
template disk tab none

Description Ruth Netser 2021-01-17 11:20:35 UTC
Created attachment 1748241 [details]
screenshot

Description of problem:
Any provided common template: as the disk contains a parameter, this is also shown in the UI with an error:
${NAME}
Disk name must start/end with alphanumberic character

Version-Release number of selected component (if applicable):
OCP 4.7.0-fc.2, CNV 2.6

How reproducible:
100%

Steps to Reproduce:
1. Virtualization -> Templates
2. Select a provided template (e.g RHEL 8)
3. Browse to the "Disks" tab

Actual results:
As the boot disk contains a parameter in the template, it is also show in the UI with an error:

${NAME}
Disk name must start/end with alphanumberic character

Expected results:
Mark it as placeholder (?) or any indication to the user that this is a parametrized value
In any case, an error should not be displayed

Additional info:
See attached screenshot

Comment 1 Guohua Ouyang 2021-01-18 06:52:58 UTC
*** Bug 1917208 has been marked as a duplicate of this bug. ***

Comment 2 Ruth Netser 2021-01-20 07:36:39 UTC
Same applies to template Details screen -> Boot Order -> "Show default boot disks"

Boot Order

No resource selected
VM will attempt to boot from disks by order of apearance in YAML file

    ${NAME} (Disk)
    cloudinitdisk (Disk)
    default (NIC)

Comment 4 Guohua Ouyang 2021-01-22 01:44:16 UTC
Created attachment 1749601 [details]
template disk tab

It shows like below now:

"${NAME}
template parameter"

Comment 5 Guohua Ouyang 2021-01-22 01:45:37 UTC
On boot disk order, it is:
${NAME} (Disk), template parameter
cloudinitdisk (Disk)
default (NIC)

Comment 6 Yaacov Zamir 2021-01-22 08:02:02 UTC
> Expected results:
> Mark it as placeholder (?) or any indication to the user that this is a parametrized value
> In any case, an error should not be displayed

it is now say "template parameter" to fix  - "indication to the user that this is a parametrized value" 
and it is not an error to fix              - "an error should not be displayed"

@Guohua hi, looks fixed to me, what am i missing here ?

Comment 7 Guohua Ouyang 2021-01-22 08:13:32 UTC
Looks I have misunderstand here, then it's fixed.

Comment 10 errata-xmlrpc 2021-02-24 15:53:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633