Bug 1917210

Summary: Inconsistent Fedora version displays on Fedora template
Product: Container Native Virtualization (CNV) Reporter: Guohua Ouyang <gouyang>
Component: SSPAssignee: Karel Šimon <ksimon>
Status: CLOSED ERRATA QA Contact: Israel Pinto <ipinto>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.6.0CC: cnv-qe-bugs, ksimon, oyahud, rnetser
Target Milestone: ---   
Target Release: 2.6.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kubevirt-ssp-operator-container-v2.6.1-5 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-07 08:46:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fedora version on UI none

Description Guohua Ouyang 2021-01-18 02:28:54 UTC
Created attachment 1748347 [details]
fedora version on UI

Description of problem:
For Fedora template, the template name is "Fedora 31+ VM", but the supported OS is "Fedora 32 or higher".
It should use either Fedora 31 or Fedora 32 in all places.

$ oc get template -n openshift fedora-desktop-large -o yaml
apiVersion: template.openshift.io/v1
kind: Template
metadata:
  annotations:
    defaults.template.kubevirt.io/disk: rootdisk
    description: 'Template for Fedora 31 VM or newer. A PVC with the Fedora disk image
      must be available. Recommended disk image: https://download.fedoraproject.org/pub/fedora/linux/releases/32/Cloud/x86_64/images/Fedora-Cloud-Base-32-1.6.x86_64.qcow2'
    iconClass: icon-fedora
    name.os.template.kubevirt.io/fedora32: Fedora 32 or higher
    name.os.template.kubevirt.io/fedora33: Fedora 32 or higher
    name.os.template.kubevirt.io/silverblue32: Fedora 32 or higher
    name.os.template.kubevirt.io/silverblue33: Fedora 32 or higher
    openshift.io/display-name: Fedora 31+ VM


Version-Release number of selected component (if applicable):
CNV 2.6

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Omer Yahud 2021-01-18 08:11:56 UTC
@ksimon Karel, can you please take this one? See if you can generate the annotation value from the os label instead of it being hard-coded

Comment 2 Ruth Netser 2021-03-30 13:05:18 UTC
Verified with SSP operator v2.6.1-5
$ oc get template -n openshift fedora-desktop-large -o yaml
apiVersion: template.openshift.io/v1
kind: Template
metadata:
  annotations:
    defaults.template.kubevirt.io/disk: rootdisk
    description: 'Template for Fedora 32 VM or newer. A PVC with the Fedora disk image
      must be available. Recommended disk image: https://download.fedoraproject.org/pub/fedora/linux/releases/32/Cloud/x86_64/images/Fedora-Cloud-Base-32-1.6.x86_64.qcow2'
    iconClass: icon-fedora
    name.os.template.kubevirt.io/fedora32: Fedora 32 or higher
    name.os.template.kubevirt.io/fedora33: Fedora 32 or higher
    name.os.template.kubevirt.io/silverblue32: Fedora 32 or higher
    name.os.template.kubevirt.io/silverblue33: Fedora 32 or higher
    openshift.io/display-name: Fedora 32+ VM
    openshift.io/documentation-url: https://github.com/kubevirt/common-templates
    openshift.io/provider-display-name: KubeVirt
    openshift.io/support-url: https://github.com/kubevirt/common-templates/issues
    operator-sdk/primary-resource: openshift-cnv/ssp-kubevirt-hyperconverged
    operator-sdk/primary-resource-type: SSP.ssp.kubevirt.io
    tags: hidden,kubevirt,virtualmachine,fedora
    template.kubevirt.io/editable: |
      /objects[0].spec.template.spec.domain.cpu.sockets
      /objects[0].spec.template.spec.domain.cpu.cores
      /objects[0].spec.template.spec.domain.cpu.threads
      /objects[0].spec.template.spec.domain.resources.requests.memory
      /objects[0].spec.template.spec.domain.devices.disks
      /objects[0].spec.template.spec.volumes
      /objects[0].spec.template.spec.networks
    template.kubevirt.io/provider: Red Hat
    template.kubevirt.io/provider-support-level: Community
    template.kubevirt.io/provider-url: https://www.fedoraproject.org
    template.kubevirt.io/version: v1alpha1
    template.openshift.io/bindable: "false"
  creationTimestamp: "2021-03-30T08:00:28Z"
  labels:
    flavor.template.kubevirt.io/large: "true"
    os.template.kubevirt.io/fedora32: "true"
    os.template.kubevirt.io/fedora33: "true"
    os.template.kubevirt.io/silverblue32: "true"
    os.template.kubevirt.io/silverblue33: "true"
    template.kubevirt.io/type: base
    template.kubevirt.io/version: v0.13.2
    workload.template.kubevirt.io/desktop: "true"

Comment 7 errata-xmlrpc 2021-04-07 08:46:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (CNV 2.6.1 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1126