Bug 1917269

Summary: vtysh running-config output not showing bgp ttl-security hops option
Product: Red Hat Enterprise Linux 8 Reporter: Carlos Goncalves <cgoncalves>
Component: frrAssignee: Michal Ruprich <mruprich>
Status: CLOSED ERRATA QA Contact: FrantiĊĦek Hrdina <fhrdina>
Severity: medium Docs Contact:
Priority: low    
Version: 8.3CC: fhrdina, michele, mruprich
Target Milestone: rcKeywords: Patch, Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: frr-7.5-6.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-10 13:36:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch none

Description Carlos Goncalves 2021-01-18 08:42:11 UTC
BGP configuration option neighbor PEER ttl-security hops NUMBER not displayed in vtysh show running-config output.

Although the configuration is not displayed, it is being set per the BGP daemon log:
2021/01/11 14:56:26 BGP: peer_ttl_security_hops_set: set gtsm_hops to 1 for uplink

Documentation: http://docs.frrouting.org/en/latest/bgp.html#clicmd-[no]neighborPEERttl-securityhopsNUMBER

This issue was reported upstream and fixed in master branch:
- https://github.com/FRRouting/frr/issues/7848
- https://github.com/donaldsharp/frr/commit/8a66632391db5f5181a4afef6aae41f48bee7fdb


Version-Release number of selected component (if applicable):
- OS Version: RHEL 8.3
- Kernel: Linux 4.18.0-240.el8.x86_64
- FRR Version: 7.5


Steps to Reproduce:
1. Set ttl-security hops in frr.conf. Example:

	hostname ctrl-3-0
	log file /var/log/frr/frr.log debugging
	service integrated-vtysh-config
	line vty

	router bgp 64999
	  bgp log-neighbor-changes
	  bgp graceful-shutdown

	  neighbor uplink peer-group
	  neighbor uplink remote-as internal
	  neighbor uplink bfd
	  neighbor uplink ttl-security hops 1
	  neighbor enp2s0 interface peer-group uplink
	  neighbor enp3s0 interface peer-group uplink

	  address-family ipv4 unicast
	    redistribute connected
	    neighbor uplink allowas-in origin
	  exit-address-family

	  address-family ipv6 unicast
	    redistribute connected
	    neighbor uplink activate
	    neighbor uplink allowas-in origin
	  exit-address-family

2. Start FRR with the BGP daemon enabled.
3. Check running configuration in vtysh

Actual results:

	[root@ctrl-3-0 frr]# vtysh -c 'show running-config'
	Building configuration...

	Current configuration:
	!
	frr version 7.5
	frr defaults traditional
	hostname ctrl-3-0
	log file /var/log/frr/frr.log
	no ipv6 forwarding
	!
	router bgp 64999
	 bgp log-neighbor-changes
	 bgp graceful-shutdown
	 neighbor uplink peer-group
	 neighbor uplink remote-as internal
	 neighbor uplink bfd
	 neighbor enp2s0 interface peer-group uplink
	 neighbor enp3s0 interface peer-group uplink
	 !
	 address-family ipv4 unicast
	  redistribute connected
	  neighbor uplink allowas-in origin
	 exit-address-family
	 !
	 address-family ipv6 unicast
	  redistribute connected
	  neighbor uplink activate
	  neighbor uplink allowas-in origin
	 exit-address-family
	!
	line vty
	!
	end


Expected results:
I would have expected to see an output line with neighbor uplink ttl-security hops 1.

Comment 1 Michal Ruprich 2021-01-27 14:40:50 UTC
Hi Carlos,

thanks for the report. The command gets applied but does not show in the running-config - I am setting the priority to low here because the command at least takes effect. Feel free to discuss the priority on this or add any customer case if there is one.

Regards,
Michal

Comment 2 Carlos Goncalves 2021-06-08 09:03:21 UTC
Any updates? This seems to be a straightforward cherry-pick from an upstream patch committed in master branch in mid-January and available in version 7.5.1 (released on March 8).

Comment 3 Michal Ruprich 2021-06-10 08:51:33 UTC
Created attachment 1789780 [details]
Patch

Comment 4 Michal Ruprich 2021-06-10 08:52:55 UTC
Hi Carlos,

yes, the cherry-pick of the patch is simple enough, frr just was not on a list to get updated in 8.5.0. I will propose this for next release since there are more bugs for FRR now.

Comment 18 errata-xmlrpc 2022-05-10 13:36:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (frr bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1778