Bug 1917510

No need to change the Fedora version as the package must be built for Rawhide first, so it's appropriate. I'll review as soon as I can.

SPEC: https://gitlab.com/lu3vea/sdrangel-fedora/-/raw/master/SPECS/airspyhf.spec
SRPM: https://gitlab.com/lu3vea/sdrangel-fedora/-/raw/master/SRPMS/airspyhf-1.6.8-1.fc32.src.rpm

Bah... fedora-review still doesn't like the gitlab links for the srpm. 

How about this, working in gitlab is fine, but once a package is ready for review the sources really need to be uploaded to fedorapeople.org. fedora-create-review will do this for you but since this one is already started, just do it manually:

$ scp airspyhf.spec airspyhf-1.6.8-1.fc32.src.rpm lu3vea:public_html/

And then update the links here of course.

Updated links:

https://lu3vea.fedorapeople.org/airspyhf-1.6.8-1.fc32.src.rpm
https://lu3vea.fedorapeople.org/airspyhf.spec

ssues:

1. Tools are GPLv2+ licensed, need to update License tag to:

"BSD and GPLv2+"

GNU General Public License v2.0 or later
----------------------------------------
airspyhf-1.6.8/libairspyhf/CMakeLists.txt
airspyhf-1.6.8/tools/CMakeLists.txt
airspyhf-1.6.8/tools/src/CMakeLists.txt
airspyhf-1.6.8/tools/src/airspyhf_calibrate.c
airspyhf-1.6.8/tools/src/airspyhf_gpio.c
airspyhf-1.6.8/tools/src/airspyhf_info.c
airspyhf-1.6.8/tools/src/airspyhf_lib_version.c
airspyhf-1.6.8/tools/src/airspyhf_rx.c

Please fix prior to importing the package

*** APPROVED ***


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
     License", "GNU General Public License v2.0 or later". 11 files have
     unknown license. Detailed output of licensecheck in
     /home/build/fedora-scm/tmp/1917510-airspyhf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/udev/rules.d,
     /usr/lib/udev
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     airspyhf-libs , airspyhf-udev , airspyhf-devel
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[?]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: airspyhf-1.6.8-1.fc34.x86_64.rpm
          airspyhf-libs-1.6.8-1.fc34.x86_64.rpm
          airspyhf-udev-1.6.8-1.fc34.x86_64.rpm
          airspyhf-devel-1.6.8-1.fc34.x86_64.rpm
          airspyhf-doc-1.6.8-1.fc34.x86_64.rpm
          airspyhf-debuginfo-1.6.8-1.fc34.x86_64.rpm
          airspyhf-debugsource-1.6.8-1.fc34.x86_64.rpm
          airspyhf-1.6.8-1.fc34.src.rpm
airspyhf.x86_64: W: invalid-license BSD-3-Clause
airspyhf.x86_64: W: no-documentation
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_calibrate
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_gpio
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_info
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_lib_version
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_rx
airspyhf-libs.x86_64: W: invalid-license BSD-3-Clause
airspyhf-libs.x86_64: W: no-documentation
airspyhf-udev.x86_64: W: invalid-license BSD-3-Clause
airspyhf-udev.x86_64: W: only-non-binary-in-usr-lib
airspyhf-udev.x86_64: W: no-documentation
airspyhf-udev.x86_64: W: empty-%post
airspyhf-udev.x86_64: W: empty-%postun
airspyhf-devel.x86_64: W: invalid-license BSD-3-Clause
airspyhf-devel.x86_64: W: no-documentation
airspyhf-doc.x86_64: W: invalid-license BSD-3-Clause
airspyhf-debuginfo.x86_64: W: invalid-license BSD-3-Clause
airspyhf-debugsource.x86_64: W: invalid-license BSD-3-Clause
airspyhf.src: W: invalid-license BSD-3-Clause
8 packages and 0 specfiles checked; 0 errors, 20 warnings.




Rpmlint (debuginfo)
-------------------
Checking: airspyhf-libs-debuginfo-1.6.8-1.fc34.x86_64.rpm
          airspyhf-debuginfo-1.6.8-1.fc34.x86_64.rpm
airspyhf-libs-debuginfo.x86_64: W: invalid-license BSD-3-Clause
airspyhf-debuginfo.x86_64: W: invalid-license BSD-3-Clause
2 packages and 0 specfiles checked; 0 errors, 2 warnings.





Rpmlint (installed packages)
----------------------------
airspyhf-libs.x86_64: W: invalid-license BSD-3-Clause
airspyhf-libs.x86_64: W: undefined-non-weak-symbol /usr/lib64/libairspyhf.so.1.6.8 sincos
airspyhf-libs.x86_64: W: undefined-non-weak-symbol /usr/lib64/libairspyhf.so.1.6.8 powf
airspyhf-libs.x86_64: W: undefined-non-weak-symbol /usr/lib64/libairspyhf.so.1.6.8 exp
airspyhf-libs.x86_64: W: undefined-non-weak-symbol /usr/lib64/libairspyhf.so.1.6.8 cos
airspyhf-libs.x86_64: W: no-documentation
airspyhf-doc.x86_64: W: invalid-license BSD-3-Clause
airspyhf.x86_64: W: invalid-license BSD-3-Clause
airspyhf.x86_64: W: no-documentation
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_calibrate
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_gpio
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_info
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_lib_version
airspyhf.x86_64: W: no-manual-page-for-binary airspyhf_rx
airspyhf-libs-debuginfo.x86_64: W: invalid-license BSD-3-Clause
airspyhf-debugsource.x86_64: W: invalid-license BSD-3-Clause
airspyhf-debuginfo.x86_64: W: invalid-license BSD-3-Clause
airspyhf-devel.x86_64: W: invalid-license BSD-3-Clause
airspyhf-devel.x86_64: W: no-documentation
airspyhf-udev.x86_64: W: invalid-license BSD-3-Clause
airspyhf-udev.x86_64: W: only-non-binary-in-usr-lib
airspyhf-udev.x86_64: W: no-documentation
airspyhf-udev.x86_64: W: empty-%post
airspyhf-udev.x86_64: W: empty-%postun
8 packages and 0 specfiles checked; 0 errors, 24 warnings.



Source checksums
----------------
https://github.com/airspy/airspyhf/archive/1.6.8/airspyhf-1.6.8.tar.gz :
  CHECKSUM(SHA256) this package     : 8ffffea5475fa824a04006b8902bae35b6b9ff3b6d685e68a7f4c2f036a78ce8
  CHECKSUM(SHA256) upstream package : cd1e5ae89e09b813b096ae4a328e352c9432a582e03fd7da86760ba60efa77ab
However, diff -r shows no differences


Requires
--------
airspyhf (rpmlib, GLIBC filtered):
    libairspyhf.so.0()(64bit)
    libc.so.6()(64bit)
    libm.so.6()(64bit)
    rtld(GNU_HASH)

airspyhf-libs (rpmlib, GLIBC filtered):
    airspyhf-udev
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    libusb-1.0.so.0()(64bit)
    rtld(GNU_HASH)

airspyhf-udev (rpmlib, GLIBC filtered):
    /bin/sh

airspyhf-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    airspyhf-libs(x86-64)
    libairspyhf.so.0()(64bit)

airspyhf-doc (rpmlib, GLIBC filtered):

airspyhf-debuginfo (rpmlib, GLIBC filtered):

airspyhf-debugsource (rpmlib, GLIBC filtered):



Provides
--------
airspyhf:
    airspyhf
    airspyhf(x86-64)

airspyhf-libs:
    airspyhf-libs
    airspyhf-libs(x86-64)
    libairspyhf.so.0()(64bit)

airspyhf-udev:
    airspyhf-udev
    airspyhf-udev(x86-64)

airspyhf-devel:
    airspyhf-devel
    airspyhf-devel(x86-64)
    pkgconfig(libairspyhf)

airspyhf-doc:
    airspyhf-doc
    airspyhf-doc(x86-64)

airspyhf-debuginfo:
    airspyhf-debuginfo
    airspyhf-debuginfo(x86-64)
    debuginfo(build-id)

airspyhf-debugsource:
    airspyhf-debugsource
    airspyhf-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1917510
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: Java, Perl, Ocaml, SugarActivity, R, fonts, Haskell, Python, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

License tag to: "BSD and GPLv2+"

https://lu3vea.fedorapeople.org/airspyhf-1.6.8-1.fc33.src.rpm

https://lu3vea.fedorapeople.org/airspyhf.spec

Emiliano,

I already approved it so no need to post spec or srpm again. Some things are considered minor enough to ask that they just get fixed before you import the package. You can now use "fedpkg request-repo ...".

Created fedpkg request-repo airspyhf-1.6.8-1 1917510

https://pagure.io/releng/fedora-scm-requests/issue/32360

Re created request repo

https://pagure.io/releng/fedora-scm-requests/issue/32706

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/airspyhf-1.6.8-1