Bug 1917980

Summary:	Should show the cert-recovery-controller version correctly
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	kube-controller-manager	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED NOTABUG	QA Contact:	zhou ying <yinzhou>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.7	CC:	aos-bugs, jokerman, knarra, mfojtik
Target Milestone:	---	Keywords:	Reopened, UpcomingSprint
Target Release:	4.6.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-02 13:29:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1911211
Bug Blocks:

Comment 1 zhou ying 2021-01-22 06:51:15 UTC

Checked with 4.6.0-0.ci.test-2021-01-22-055421-ci-ln-jq80922, the version info changed to :

[root@dhcp-140-138 roottest]# oc get clusterversion 
NAME      VERSION                                           AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.6.0-0.ci.test-2021-01-22-055421-ci-ln-jq80922   True        False         11m     Cluster version is 4.6.0-0.ci.test-2021-01-22-055421-ci-ln-jq80922


[root@dhcp-140-138 roottest]# oc logs -f po/kube-controller-manager-ci-ln-jq80922-f76d1-xjrpn-master-0 -c kube-controller-manager-recovery-controller
......
I0122 06:28:38.254696       1 builder.go:238] cert-recovery-controller version v0.0.0-alpha.0-855-g19a1fb2-19a1fb24

Comment 4 Maciej Szulik 2021-03-01 11:24:29 UTC

Jan you dealt with the other of this kind, can you close this too?

Comment 5 Jan Chaloupka 2021-03-01 12:32:59 UTC

Checking with 4.8.0-0.nightly-2021-03-01-031258:

```
$ oc logs -n openshift-kube-controller-manager kube-controller-manager-ip-10-0-128-102.ec2.internal -c kube-controller-manager-recovery-controller
+ timeout 3m /bin/bash -exuo pipefail -c 'while [ -n "$(ss -Htanop \( sport = 9443 \))" ]; do sleep 1; done'
++ ss -Htanop '(' sport = 9443 ')'
+ '[' -n '' ']'
+ exec cluster-kube-controller-manager-operator cert-recovery-controller --kubeconfig=/etc/kubernetes/static-pod-resources/configmaps/kube-controller-cert-syncer-kubeconfig/kubeconfig --namespace=openshift-kube-controller-manager --listen=0.0.0.0:9443 -v=2
W0301 09:31:05.546091       1 cmd.go:204] Using insecure, self-signed certificates
I0301 09:31:05.546861       1 crypto.go:601] Generating new CA for cert-recovery-controller-signer@1614591065 cert, and key in /tmp/serving-cert-665978849/serving-signer.crt, /tmp/serving-cert-665978849/serving-signer.key
I0301 09:31:06.277218       1 observer_polling.go:159] Starting file observer
I0301 09:31:06.313947       1 builder.go:238] cert-recovery-controller version 4.8.0-202102270107.p0-79ab913-79ab913efd9c079f8cc7598d9130e7da48b3242c
```

Comment 6 Jan Chaloupka 2021-03-02 13:29:15 UTC

The controller logs still contain at least the sha1 hash sufficient for identifying the KCM's commit. So, improving the reported version is only a cosmetic change. No need to backport the changes into 4.7 or lower.