Bug 1918078

Summary:	Review Request: luit - Locale and ISO 2022 support for Unicode terminals
Product:	[Fedora] Fedora	Reporter:	Adam Jackson <ajax>
Component:	Package Review	Assignee:	Mattia Verga <mattia.verga>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, mattia.verga, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-10 14:02:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Jackson 2021-01-20 01:29:15 UTC

Spec URL: https://ajax.fedorapeople.org/deagg/apps/luit.spec
SRPM URL: https://ajax.fedorapeople.org/deagg/apps/luit-20201003-1.fc32.src.rpm
Description: Luit is a filter that can be run between an arbitrary application and a UTF-8 terminal emulator. It will convert application output from the locale's encoding into UTF-8, and convert terminal input from UTF-8 into the locale's encoding. It is mainly used to support xterm.
Fedora Account System Username: ajax

This is for https://fedoraproject.org/wiki/Changes/XorgUtilityDeaggregation , the xorg-x11-apps package will be updated to match. Note that this review is also switching to an actually active upstream.

Comment 1 Artur Frenszek-Iwicki 2021-01-22 10:58:18 UTC

>Source0:        https://invisible-island.net/datafiles/release/luit.tar.gz
This will always point to the latest release, which makes reproducing builds harder.
How about using "ftp://ftp.invisible-island.net/luit/luit-%{version}.tgz" instead?

>%install
>rm -rf $RPM_BUILD_ROOT
Don't remove the buildroot at start of %install.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

Comment 2 Adam Jackson 2021-02-24 16:25:54 UTC

(In reply to Artur Frenszek-Iwicki from comment #1)
> >Source0:        https://invisible-island.net/datafiles/release/luit.tar.gz
> This will always point to the latest release, which makes reproducing builds
> harder.
> How about using "ftp://ftp.invisible-island.net/luit/luit-%{version}.tgz"
> instead?

ftp isn't exactly a reliable step, if "reproducing the build" is an issue. I found what looks like a stable https url with the version number though.

> >%install
> >rm -rf $RPM_BUILD_ROOT
> Don't remove the buildroot at start of %install.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

Sure, done. spec and srpm updated, same URLs as above.

Comment 3 Mattia Verga 2021-03-10 14:02:56 UTC

While doing the review, I've discovered this has already been packaged by someone else:
https://bugzilla.redhat.com/show_bug.cgi?id=1933934

However, they use source code from X.Org which is quite old (version 1.1.1 from 2012), so you'd better coordinate with them if you want/need a newer version to be packaged. (BTW a 20210218 version is available).

*** This bug has been marked as a duplicate of bug 1933934 ***