Bug 1918132

Summary: i18n: Volume Snapshot Contents menu is not translated
Product: OpenShift Container Platform Reporter: Yadan Pei <yapei>
Component: Management ConsoleAssignee: ralpert
Status: CLOSED ERRATA QA Contact: Siva Reddy <schituku>
Severity: low Docs Contact:
Priority: low    
Version: 4.7CC: aos-bugs, jokerman, ralpert, yapei
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Text was not internationalized. Consequence: Text was not pseudolocalizable or translated like the rest of the menu. Fix: Internationalized the text. Result: Bug is fixed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-24 15:54:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Volume Snapshot Contents not translated
none
Add Secret to Workload modal not translated
none
Add Storage page not translated
none
After the fix not translated
none
Screenshot of translated text after fix none

Description Yadan Pei 2021-01-20 07:22:18 UTC
Created attachment 1748958 [details]
Volume Snapshot Contents not translated

Description of problem:
as title

Version-Release number of selected component (if applicable):
4.7.0-0.nightly-2021-01-19-095812

How reproducible:
Always

Steps to Reproduce:
1. visit console and add ?pseudolocalization=true&lng=en suffix
2. check if all menus are translated
3.

Actual results:
2. `Volume Snapshot Contents` sub menu is not translated

Expected results:
2. `Volume Snapshot Contents` sub menu should be marked for translation

Additional info:

Comment 1 Yadan Pei 2021-01-20 07:26:01 UTC
Created attachment 1748959 [details]
Add Secret to Workload modal not translated

Comment 2 Yadan Pei 2021-01-20 07:26:42 UTC
Created attachment 1748960 [details]
Add Storage page not translated

Comment 3 Yadan Pei 2021-01-20 07:28:24 UTC
`Add Secret to Workload` modal and `Add Storage` page are also not translated, let me know if they need to be tracked in separate bug

Comment 4 ralpert 2021-01-22 15:45:47 UTC
Hey @yapei - I believe the "Add Secret to Workload" modal and "Add Storage" are being addressed as part of https://github.com/openshift/console/pull/7720/file. I can update the nav item though. Thanks for flagging!

Comment 6 Siva Reddy 2021-01-27 02:01:54 UTC
Still the volume snapshot contents is not marked for translation so returning the bug.
attached the screenshot.

# git log 85d737a55d24f59c9cda1e49d2e29daac3f730c1 | grep '#7906'
    Merge pull request #7906 from rebeccaalpert/i18n-nav-update

Version:
 4.7.0-0.nightly-2021-01-26-162323

Comment 7 Siva Reddy 2021-01-27 02:03:34 UTC
Created attachment 1751082 [details]
After the fix not translated

Comment 8 ralpert 2021-01-27 14:51:12 UTC
Created attachment 1751285 [details]
Screenshot of translated text after fix

Comment 9 ralpert 2021-01-27 14:51:18 UTC
Hey @schituku - It's fine on master. Attaching a screenshot as well.

Comment 10 Siva Reddy 2021-01-28 03:19:25 UTC
@ralpert  now I can see it. Its strange that inspite of the pull req being in the image the earlier version did not update

Version:
4.7.0-0.nightly-2021-01-27-192705

Now the items are marked for translation.

Comment 11 Siva Reddy 2021-01-28 03:20:44 UTC
removing the need info flag.

Comment 12 ralpert 2021-01-28 14:16:13 UTC
Thanks Siva! It is really weird.

Comment 15 errata-xmlrpc 2021-02-24 15:54:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633