Bug 1918357

Summary: Rebase python-blivet to latest upstream release
Product: Red Hat Enterprise Linux 8 Reporter: Vojtech Trefny <vtrefny>
Component: python-blivetAssignee: Vojtech Trefny <vtrefny>
Status: CLOSED ERRATA QA Contact: Release Test Team <release-test-team-automation>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.5CC: jikortus, jstodola, pkotvan, vponcova
Target Milestone: rcKeywords: Rebase, Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-blivet-3.4.0-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1964341 (view as bug list) Environment:
Last Closed: 2021-11-09 18:49:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1964341    

Description Vojtech Trefny 2021-01-20 14:24:44 UTC
We should rebase blivet in 8.5 to the latest upstream version 3.4 (currently in development) which contains numerous bugfixes and new features like LVM VDO support.

Comment 1 Vojtech Trefny 2021-01-28 15:28:56 UTC
List of notable changes in 3.3 release:
- XFS resize support: already backported to RHEL 8.4 https://bugzilla.redhat.com/show_bug.cgi?id=1862349
- F2FS support: mkfs only, f2fs-tools are not available in RHEL so this should not affect RHEL 8
- Better handling of unknown Device Mapper devices: blivet should no longer crash when an unknown DM device is present, instead we should be able to add it as a "basic" DMDevice and teardown/remove it
- basic LVM VDO support: already backported to 8.4 https://bugzilla.redhat.com/show_bug.cgi?id=1828745
- localization platform change from Zanata to Weblate: should affect only release process
- terminology cleanup: we changed some problematic terminology (slaves, blacklists etc.), this includes some API changes and will require Anaconda to backport https://github.com/rhinstaller/anaconda/pull/2698

Full list of changes: https://github.com/storaged-project/blivet/releases/tag/blivet-3.3.0

Planned changes for 3.4 release:
- full LVM VDO support (planned for backport to RHEL 8.4 https://bugzilla.redhat.com/show_bug.cgi?id=1509337)

Stratis support is also currently being worked on, but because it isn't supported in RHEL 8 we'll probably not include it in 3.4.0 to make the release smaller for the rebase.

Comment 2 Jan Stodola 2021-04-20 09:34:58 UTC
The following change is part of 3.3 release:
https://github.com/storaged-project/blivet/pull/794

Since it changes the API, it needs to be reverted for RHEL-8 and verified the change is not included in RHEL-8.

Comment 3 Vojtech Trefny 2021-05-07 15:51:32 UTC
I've just released 3.4.0 upstream release: https://github.com/storaged-project/blivet/releases/tag/blivet-3.4.0 The biggest change is the LVM VDO support, other that fixes for some small issues both in RHEL and Fedora and some small test suite changes.(In reply to Jan Stodola from comment #2)


> The following change is part of 3.3 release:
> https://github.com/storaged-project/blivet/pull/794
> 
> Since it changes the API, it needs to be reverted for RHEL-8 and verified
> the change is not included in RHEL-8.

I agree. We should also revert https://github.com/storaged-project/blivet/pull/889 from 3.3 which also introduces some API changes.

Comment 4 Jan Stodola 2021-05-18 11:09:24 UTC
Vendy, would there be any anaconda changes needed if blivet is rebased to 3.4 in RHEL-8.5?

Comment 5 Vendula Poncova 2021-05-21 10:40:46 UTC
I am not aware of any needed changes in Anaconda.

Comment 6 Vojtech Trefny 2021-05-26 12:23:42 UTC
I've prepared the rebased build for testing. Gating tests are passing and I'm currently trying to run installer kickstart test suite against it.

PR against the rhel8-branch in our upstream repo: https://github.com/storaged-project/blivet/pull/961

scratch build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=36990993

scratch build repo: http://brew-task-repos.usersys.redhat.com/repos/scratch/vtrefny/python-blivet/3.4.0/1.el8/

dist-git PR: https://src.osci.redhat.com/rpms/python-blivet/pull-request/18

Comment 17 Vojtech Trefny 2021-10-08 10:48:42 UTC
*** Bug 1888287 has been marked as a duplicate of this bug. ***

Comment 18 Vojtech Trefny 2021-10-08 10:49:04 UTC
*** Bug 1855726 has been marked as a duplicate of this bug. ***

Comment 19 Vojtech Trefny 2021-10-08 10:49:28 UTC
*** Bug 1880298 has been marked as a duplicate of this bug. ***

Comment 21 errata-xmlrpc 2021-11-09 18:49:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (python-blivet bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4297