Bug 1918405
| Summary: | Review Request: tiddlywiki - A non-linear personal web notebook for Node.js and browsers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-04-15 00:45:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
W. Michael Petullo
2021-01-20 16:20:00 UTC
Have you considered: https://fedoraproject.org/wiki/Changes/NodejsLibrariesBundleByDefault ?
- How is this generated:
Source1: %{npm_name}-%{version}-nm-dev.tgz
Add a comment to explain it.
- You unzip Source1 but do not run tests with it?
%check
%{__nodejs} -e 'require("./")'
# Setup bundled dev node_modules for testing
# Note: this cannot be in %%prep or the dev node_modules
# can get pulled into the regular rpm
tar xfz %{SOURCE1}
- Package should start with:
%{?nodejs_find_provides_and_requires}
- %nodejs_symlink_deps should be run at the end of install
- I suggest naming the package tiddlywiki if this is a standalone application
- What's the point of Source2: %{npm_name}-%{version}-bundled-licenses.txt?
There is already a "license" file with the BSD copy.
Spec URL: https://www.flyn.org/SRPMS/tiddlywiki.spec SRPM URL: https://www.flyn.org/SRPMS/tiddlywiki-5.1.23-2.fc33.src.rpm - Make use of nodejs_find_provides_and_requires macro - Make use of nodejs_symlink_deps macro - Rename package from nodejs-tiddlywiki to tiddlywiki - Drop ...bundled-licenses.txt, use install, which is distributed with source - Drop ...-nm-dev.tgz - Something is wrong with the package, the only .js shipped contains:
#!/usr/bin/env node
/*
This is invoked as a shell script by NPM when the `tiddlywiki` command is typed
*/
var $tw = require("./boot/boot.js").TiddlyWiki();
// Pass the command line arguments to the boot kernel
$tw.boot.argv = Array.prototype.slice.call(process.argv,2);
// Boot the TW5 app
$tw.boot.boot();
no other js is shipped so I don't see how this package could work. There are tons of other files in the archive that you don't install.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |