Bug 1918708

Summary:	Support Link non uplink representors to PCI device
Product:	Red Hat Enterprise Linux 8	Reporter:	Moshe Levi <moshele>
Component:	libvirt	Assignee:	Laine Stump <laine>
Status:	CLOSED ERRATA	QA Contact:	yalzhang <yalzhang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.3	CC:	ahleihel, hakhande, jdenemar, jsuchane, laine, virt-maint, xuzhang, yalzhang
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-6.0.0-34.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-18 15:23:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Moshe Levi 2021-01-21 12:33:42 UTC

Description of problem: 

Due to new kernel patch here [1], the PF and VF representors are linked to their parent PCI device.

Old Structure:
The structure of VF's PCI Address/physfn/net contains only the PF of that VF

$ ls /sys/bus/pci/devices/<vf-pci-addre>/physfn/net/
enp2s0f0

$ ls -l /sys/class/net
...
lrwxrwxrwx 1 root root 0 Aug 17 11:11 enp2s0f0_0 -> ../../devices/virtual/net/enp2s0f0_0
lrwxrwxrwx 1 root root 0 Aug 17 11:11 enp2s0f0_1 -> ../../devices/virtual/net/enp2s0f0_1
lrwxrwxrwx 1 root root 0 Aug 17 11:11 enp2s0f0_2 -> ../../devices/virtual/net/enp2s0f0_2
lrwxrwxrwx 1 root root 0 Aug 17 11:11 enp2s0f0_3 -> ../../devices/virtual/net/enp2s0f0_3
...

New Structure:
The structure of VF's PCI Address/physfn/net contains the PF of that VF and the VF representors

$ ls /sys/bus/pci/devices/<vf-pci-addre>/physfn/net/
enp3s0f0 enp3s0f0_0 enp3s0f0_1 enp3s0f0_2 enp3s0f0_3

$ ls -l /sys/class/net
...
lrwxrwxrwx. 1 root root 0 Aug 17 08:43 enp3s0f0_0 -> ../../devices/pci0000:00/0000:00:02.0/0000:03:00.0/net/enp3s0f0_0
lrwxrwxrwx. 1 root root 0 Aug 17 08:43 enp3s0f0_1 -> ../../devices/pci0000:00/0000:00:02.0/0000:03:00.0/net/enp3s0f0_1
lrwxrwxrwx. 1 root root 0 Aug 17 08:43 enp3s0f0_2 -> ../../devices/pci0000:00/0000:00:02.0/0000:03:00.0/net/enp3s0f0_2
lrwxrwxrwx. 1 root root 0 Aug 17 08:43 enp3s0f0_3 -> ../../devices/pci0000:00/0000:00:02.0/0000:03:00.0/net/enp3s0f0_3
...

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=123f0f53dd64b67e34142485fe866a8a581f12f1

Version-Release number of selected component (if applicable):
we need to update libvirt to support it as well



Actual results:
create vm with SR-IOV switchdev will failed

Expected results:
vm should boot successfully 

Additional info:
patch posted in https://www.redhat.com/archives/libvir-list/2021-January/msg00843.html

Comment 1 Alaa Hleihel (NVIDIA Mellanox) 2021-01-21 12:56:22 UTC

related to BZ 1908649

Comment 2 Jaroslav Suchanek 2021-01-25 16:11:30 UTC

(In reply to Alaa Hleihel (NVIDIA Mellanox) from comment #1)
> related to BZ 1908649

Hi Alaa, the referenced bz is for Red Hat Enterprise Advanced Virtualization product. Do you know if this an issue which should be addressed in RHEL-8 as well?

Comment 3 Alaa Hleihel (NVIDIA Mellanox) 2021-01-26 08:06:54 UTC

(In reply to Jaroslav Suchanek from comment #2)
> (In reply to Alaa Hleihel (NVIDIA Mellanox) from comment #1)
> > related to BZ 1908649
> 
> Hi Alaa, the referenced bz is for Red Hat Enterprise Advanced Virtualization
> product. Do you know if this an issue which should be addressed in RHEL-8 as
> well?

Hi, Jaroslav.

Yes, this should be fixed in RHEL as well.

Thanks
Alaa

Comment 4 Alaa Hleihel (NVIDIA Mellanox) 2021-01-26 08:15:53 UTC

In addition, this issue affects our out-of-box driver (MLNX_OFED), so can the fix
be backported to z-stream releases as well?

Comment 6 yalzhang@redhat.com 2021-02-02 02:04:15 UTC

Test on libvirt-6.0.0-34.module+el8.4.0+9758+5c420eed.x86_64 with the steps in bug 1908649#c13, it is as expected.

Comment 9 yalzhang@redhat.com 2021-02-02 13:21:21 UTC

set it as verified as comment 6

Comment 11 errata-xmlrpc 2021-05-18 15:23:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1762